]> source.dussan.org Git - gitea.git/commit
Improve install code to avoid low-level mistakes. (#17779)
authorwxiaoguang <wxiaoguang@gmail.com>
Wed, 1 Dec 2021 07:50:01 +0000 (15:50 +0800)
committerGitHub <noreply@github.com>
Wed, 1 Dec 2021 07:50:01 +0000 (15:50 +0800)
commit042cac5fedeec8af53080b9666fe043072f3a6be
treeb13d57faa71ba8bc9f8b3d40f5be7e3735ac66a4
parenta3517d8668482b58cb80ba10a956fe4e27e1a429
Improve install code to avoid low-level mistakes. (#17779)

* Improve install code to avoid low-level mistakes.

If a user tries to do a re-install in a Gitea database, they gets a warning and double check.
When Gitea runs, it never create empty app.ini automatically.

Also some small (related) refactoring:

* Refactor db.InitEngine related logic make it more clean (especially for the install code)
* Move some i18n strings out from setting.go to make the setting.go can be easily maintained.
* Show errors in CLI code if an incorrect app.ini is used.
* APP_DATA_PATH is created when installing, and checked when starting (no empty directory is created any more).
36 files changed:
cmd/cmd.go
cmd/convert.go
cmd/doctor.go
cmd/dump.go
cmd/dump_repo.go
cmd/embedded.go
cmd/mailer.go
cmd/migrate.go
cmd/migrate_storage.go
cmd/restore_repo.go
cmd/serv.go
cmd/web.go
contrib/environment-to-ini/environment-to-ini.go
contrib/pr/checkout.go
integrations/integration_test.go
integrations/migration-test/migration_test.go
models/db/engine.go
models/db/install/db.go [new file with mode: 0644]
models/migrations/migrations_test.go
models/ssh_key_test.go
models/unittest/fixtures.go
models/unittest/testdb.go
modules/doctor/doctor.go
modules/doctor/paths.go
modules/private/internal.go
modules/setting/directory.go [new file with mode: 0644]
modules/setting/i18n.go [new file with mode: 0644]
modules/setting/setting.go
options/locale/locale_en-US.ini
routers/init.go
routers/install/install.go
routers/install/setting.go
services/forms/user_form.go
templates/base/head.tmpl
templates/install.tmpl
web_src/less/_install.less