]> source.dussan.org Git - gitea.git/commit
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT`...
authorZettat123 <zettat123@gmail.com>
Thu, 31 Oct 2024 15:28:25 +0000 (23:28 +0800)
committerGitHub <noreply@github.com>
Thu, 31 Oct 2024 15:28:25 +0000 (15:28 +0000)
commit0690cb076bf63f71988a709f62a9c04660b51a4f
tree476e377eff422fd86c11c78f49b0ef3b7f3e9fc3
parent810782302652d73c4f7249c4c3df8a7e85bae5f0
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365)

Fix #28121

I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.

https://github.com/go-gitea/gitea/blob/348d1d0f322ca57c459acd902f54821d687ca804/routers/api/packages/container/container.go#L712-L717
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>

In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.

```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```

---

Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.

https://github.com/go-gitea/gitea/blob/b7fb20e73e63b8edc9b90c52073e248bef428fcc/modules/storage/minio.go#L214-L221
19 files changed:
modules/packages/content_store.go
modules/storage/azureblob.go
modules/storage/helper.go
modules/storage/helper_test.go
modules/storage/local.go
modules/storage/minio.go
modules/storage/storage.go
routers/api/actions/artifacts.go
routers/api/actions/artifactsv4.go
routers/api/packages/container/container.go
routers/api/packages/maven/maven.go
routers/api/v1/repo/file.go
routers/web/base.go
routers/web/repo/actions/view.go
routers/web/repo/attachment.go
routers/web/repo/download.go
routers/web/repo/repo.go
services/lfs/server.go
services/packages/packages.go