]> source.dussan.org Git - vaadin-framework.git/commit
Always calculate Escalator max row count the same way (#8740)
authorArtur <artur@vaadin.com>
Tue, 7 Mar 2017 10:44:01 +0000 (12:44 +0200)
committerHenri Sara <henri.sara@gmail.com>
Tue, 7 Mar 2017 10:44:01 +0000 (12:44 +0200)
commit0c5414744b720da51aedace58b9efa21ecd4bd0e
tree1ff08e689abfbc098ff26ba72e7ad6df0df32ba1
parentf25041bfabd1e3b13a2a9bd85289098d33699cc2
Always calculate Escalator max row count the same way (#8740)

* Rename getMaxEscalatorRowCapacity to describe what it does

* Always calculate Escalator max row count the same way

This changes Escalator to not take a horizontal scrollbar
into account when trying to determine "maximum visible rows". This will
add another row, compared to previous versions, when there is a horizontal
scrollbar. In reality, it would likely make sense to always add 10 more rows
to have some buffer above and below the visible area.

Fixes #8661
client/src/main/java/com/vaadin/client/widgets/Escalator.java
uitest/src/main/java/com/vaadin/tests/components/grid/HideGridColumnWhenHavingUnsuitableHeight.java [new file with mode: 0644]
uitest/src/test/java/com/vaadin/tests/components/grid/HideGridColumnWhenHavingUnsuitableHeightTest.java [new file with mode: 0644]
uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/escalator/EscalatorSpacerTest.java
uitest/src/test/java/com/vaadin/tests/components/grid/basicfeatures/server/GridScrollTest.java