]> source.dussan.org Git - nextcloud-server.git/commit
Replace "named" Mink selectors with "named_exact" Mink selectors 4662/head
authorDaniel Calviño Sánchez <danxuliu@gmail.com>
Tue, 2 May 2017 12:33:34 +0000 (14:33 +0200)
committerDaniel Calviño Sánchez <danxuliu@gmail.com>
Tue, 2 May 2017 13:09:38 +0000 (15:09 +0200)
commit1381f6c131d7e4cd6bdb88c567adf771f2a3c463
tree41298cb7e82a88ad0ec5ff5d595bb869f9d7d90b
parent762a8e0b76e121f108269b916de9d68ff5ffaa9c
Replace "named" Mink selectors with "named_exact" Mink selectors

The "named" Mink selector first tries to find an exact match for its
locator and then, if not found, tries to find a partial match. Besides
other harder to track problems (see comment in the commit in which the
"content" locator was removed), this could cause, for example, finding
an action link titled "Favorited" when looking for the action link
titled "Favorite" (that is, one that conveys the opposite state to the
one found).

Although currently all the acceptance tests are compatible with both the
"named" and the "named_exact" Mink selectors the predefined locators are
modified to use the "named_exact" Mink selector to make them more
future-proof; the "named" Mink selector can still be used if needed
through the "customSelector" method in the builder object.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
tests/acceptance/features/core/Locator.php