]> source.dussan.org Git - jgit.git/commit
Suppress "Unlikely argument type for equals()" warnings in tests 61/106061/4
authorDavid Pursehouse <david.pursehouse@gmail.com>
Sun, 1 Oct 2017 05:08:17 +0000 (06:08 +0100)
committerMatthias Sohn <matthias.sohn@sap.com>
Mon, 6 Nov 2017 09:34:34 +0000 (10:34 +0100)
commit190b575be1fb78f1dc5d0be7f469c2b08f4d614d
treeb9edad7b0c878a4f20d46bcaa858fc0c6497b3ca
parent021e72b8011c6c0e1bc1f6b3c6494dc57f85f1a2
Suppress "Unlikely argument type for equals()" warnings in tests

This new warning was introduced in Eclipse 4.7 Oxygen [1].

The only instances of the warning are in test code that is asserting
that some class does not compare equal to Strings. As in the Gerrit
project [2] these asserts are arguably overkill, but arguably also
a reasonable test of an equals implementation. Ignore the warning in
these cases.

Note that if the project is opened in an earlier version of Eclipse,
a warning "Unsupported @SuppressWarnings" will be emitted.

[1] https://www.eclipse.org/eclipse/news/4.7/M6/
[2] https://gerrit-review.googlesource.com/#/c/gerrit/+/110339/

Change-Id: I08ea33d71e6009cf0f37e6492a475931f447256b
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.lfs.test/tst/org/eclipse/jgit/lfs/lib/AbbreviatedLongObjectIdTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/diff/EditListTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/diff/EditTest.java
org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/RevObjectTest.java