]> source.dussan.org Git - nextcloud-server.git/commit
relax strict getHome behaviour for LDAP users in a shadow state 18884/head
authorArthur Schiwon <blizzz@arthur-schiwon.de>
Mon, 28 Oct 2019 14:11:41 +0000 (15:11 +0100)
committerArthur Schiwon <blizzz@arthur-schiwon.de>
Fri, 28 Feb 2020 17:04:50 +0000 (18:04 +0100)
commit2056758d876d386a3419f215e168c85b6a3469e4
treeace9a360456151d0419225cfcd40b7a4cbda971e
parent2ecedeabe44cc2f566d304a25861370dfcdea26a
relax strict getHome behaviour for LDAP users in a shadow state

* simplifies deletion process
* less strange behaviour when looking up home storage (as long as it is local)
* thus could enable transfer ownerships after user went invisible on ldap

backport of #17717

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
decouple userExists from userExistsOnLDAP check

allows to mark users as offline right away, avoids a gap of being not a
user and causing weird side effects

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
adjust tests

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
remove superfluous tests

- user_ldap is not exposed to public api, it is always behind ldap_proxy
- this is too much for a unit test
- integration tests cover userExists implicitly

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
ensure that only valid group members are returned

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
apps/user_ldap/lib/Group_LDAP.php
apps/user_ldap/lib/User/User.php
apps/user_ldap/lib/User_LDAP.php
apps/user_ldap/lib/User_Proxy.php
apps/user_ldap/tests/User_LDAPTest.php