]> source.dussan.org Git - nextcloud-server.git/commit
I dug into it again, and the issue is much simpler than I previously though. 35946/head
authorLouis Chemineau <louis@chmn.me>
Tue, 6 Sep 2022 08:58:01 +0000 (10:58 +0200)
committerbackportbot-nextcloud[bot] <backportbot-nextcloud[bot]@users.noreply.github.com>
Mon, 2 Jan 2023 15:30:15 +0000 (15:30 +0000)
commit34a93a0e12a2e1cb318093d9787fe929daee65e5
tree6529e5d694ddd7eef8d0759e38227059a0e6314e
parent6881d200ad72a881dc4449ca38153f85d966195f
I dug into it again, and the issue is much simpler than I previously though.

- LDAP has an email address with capital letters
- NC store this address in lower case
- When the user logs in, we compare the [stored email with the new lower case email](https://github.com/nextcloud/server/blob/master/lib/private/AllConfig.php#L259-L261) before storing it. Here, both email will be the same, so we won't store the new email address with upper case letters. Which is what we want.
- We then [compare emails as they are before triggering an event](https://github.com/nextcloud/server/blob/master/lib/private/User/User.php#L202-L204), they won't match, so the user will receive an email signaling an email change every time he logs in.

The fix is to compare the old email with the new lower case email before sending the event.

Signed-off-by: Louis Chemineau <louis@chmn.me>
lib/private/User/User.php