]> source.dussan.org Git - gitea.git/commit
Don't prevent overflow on y-as (#19978)
authorGusted <williamzijl7@hotmail.com>
Thu, 16 Jun 2022 14:49:22 +0000 (16:49 +0200)
committerGitHub <noreply@github.com>
Thu, 16 Jun 2022 14:49:22 +0000 (22:49 +0800)
commit36127a3336d3e124f9ea67d4bcf4b76e9a7a07b6
tree1cd42a98e152d32773210824599d81520ff33e36
parentd05fb6f6c96b536567911ac077b53a0b03717f29
Don't prevent overflow on y-as (#19978)

- Fomantic tries to prevent overflowing on the `y/x`-as by default on
stackable menu's on mobile screens. We already solve this issue by
forcing overflow on x as and hide it on y as(due to some issues with
other menu's), since https://github.com/go-gitea/gitea/pull/19486.
- However this edge case does require a y-overflow to show the dropdown,
because you cannot easily adjust this with CSS, once you're fiddling
with overflow's (https://stackoverflow.com/a/6433475). However
interesting behavior is noted
https://css-tricks.com/popping-hidden-overflow/ when you remove the
position: relative, it will suddenly work again. Well because this is
the only solution without redesigning dropdowns, I think we can live
with the side-effect of the dropdown items being full-width instead
"relative" width to their parent.
- Resolves #19976

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
web_src/less/_base.less