]> source.dussan.org Git - jgit.git/commit
Call AdvertiseRefsHook before validating wants 46/134446/2
authorMasaya Suzuki <masayasuzuki@google.com>
Tue, 18 Dec 2018 17:20:54 +0000 (09:20 -0800)
committerJonathan Nieder <jrn@google.com>
Mon, 24 Dec 2018 03:24:26 +0000 (19:24 -0800)
commit3a529361a76e8267467071e0b13ebb36b97d8fb2
tree56636296c6877d3b39173ecafcd060839f86ef58
parentc31108bcc55eaf06b2047b9ab284cbf9cd29ebf6
Call AdvertiseRefsHook before validating wants

AdvertiseRefsHook is used to limit the visibility of the refs in Gerrit.
If this hook is not called, then all refs are treated as visible,
causing the server to serve commits reachable from branches the client
should not be able to access, if asked to via a request naming a guessed
object id.

This bug was introduced in v2.0.0.201206130900-r~123 (Modify refs in
UploadPack/ReceivePack using a hook interface, 2012-02-08).  Stateful
bidirectional transports are not affected.

Fix it by moving the AdvertiseRefsHook call to
getAdvertisedOrDefaultRefs, ensuring the hook is called in all cases.

[jn: backported to stable-4.5 by splitting out tests and the protocol v2
 specific parts]

Change-Id: I159f396216354f2eda3968d17802e166d8c8ec2d
Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>
org.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java