]> source.dussan.org Git - gitea.git/commit
Clarify permission "HasAccess" behavior (#30585)
authorwxiaoguang <wxiaoguang@gmail.com>
Sat, 20 Apr 2024 03:15:04 +0000 (11:15 +0800)
committerGitHub <noreply@github.com>
Sat, 20 Apr 2024 03:15:04 +0000 (03:15 +0000)
commit48d4580dd5e975de2e8207bb9b9a2f258711d38c
tree4a2fbca0b792b37f09014952a7325bbb09e7ac97
parent89e39872fff39797107acafb984dc2dc3ec3dd6a
Clarify permission "HasAccess" behavior (#30585)

Follow #30495

"HasAccess" behavior wasn't clear, to make it clear:

* Use a new name `HasAnyUnitAccess`, it will be easier to review related
code and permission problems.
* Separate everyone access mode to a separate field, then all calls to
HasAccess are reverted to old behavior before #30495.
* Add new tests.

---------

Co-authored-by: Giteabot <teabot@gitea.io>
13 files changed:
models/org_team.go
models/perm/access/access_test.go
models/perm/access/repo_permission.go
models/perm/access/repo_permission_test.go
routers/api/v1/api.go
routers/api/v1/repo/repo.go
routers/web/user/package.go
services/context/repo.go
services/convert/package.go
services/repository/delete.go
services/repository/transfer.go
services/repository/transfer_test.go
tests/integration/api_repo_test.go