]> source.dussan.org Git - jgit.git/commit
ObjectWalk: make setRetainBody(false) the default 68/47568/3
authorShawn Pearce <spearce@spearce.org>
Sat, 9 May 2015 17:47:13 +0000 (10:47 -0700)
committerShawn Pearce <spearce@spearce.org>
Sun, 10 May 2015 17:45:34 +0000 (10:45 -0700)
commit53e39094bf012a4f5b3fe5557219707cb7b0f010
treea1f7352fad14868f6b37bf29a2ccc3a2535610d8
parent3d06349ff21e157fc837ef09e48a5e400afb4e6a
ObjectWalk: make setRetainBody(false) the default

Despite being the primary author of RevWalk and ObjectWalk I still
fail to remember to setRetainBody(false) in application code using
an ObjectWalk to examine the graph.

Document the default for RevWalk is setRetainBody(true), where the
application usually wants the commit bodies to display or inspect.

Change the default for ObjectWalk to setRetainBody(false), as nearly
all callers want only the graph shape and do not need the larger text
inside a commit body. This allows some code in JGit to be simplified.

Change-Id: I367e42209e805bd5e1f41b4072aeb2fa98ec9d99
org.eclipse.jgit.test/tst/org/eclipse/jgit/revwalk/FooterLineTest.java
org.eclipse.jgit/src/org/eclipse/jgit/api/StashCreateCommand.java
org.eclipse.jgit/src/org/eclipse/jgit/api/StashListCommand.java
org.eclipse.jgit/src/org/eclipse/jgit/blame/BlameGenerator.java
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackWriter.java
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/ObjectWalk.java
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevCommit.java
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevTag.java
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/RevWalk.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/BaseReceivePack.java