]> source.dussan.org Git - jgit.git/commit
LfsProtocolServlet: Allow getLargeFileRepository to raise exceptions 09/78109/3
authorDavid Pursehouse <david.pursehouse@gmail.com>
Fri, 29 Jul 2016 03:37:48 +0000 (12:37 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Fri, 5 Aug 2016 02:22:27 +0000 (11:22 +0900)
commit571c9f5fd6f7c25f0729088e4f23bb38ea743e7b
treed398a0a710322469fc51334192356ad24ad7643d
parent1ce24d46a6db83f074b4eafc80be799727b988a4
LfsProtocolServlet: Allow getLargeFileRepository to raise exceptions

According to the specification [1] the server may return the following
HTTP error responses:

- 403: The user has read, but not write access.
- 404: The repository does not exist for the user.
- 422: Validation error with one or more of the objects in the request.

In the current implementation, however, getLargeFileRepository can only
return null to indicate an error. This results in the error code:

- 503: Service Unavailable

being returned to the client regardless of what the actual reason was.

Add exception classes to cover these cases, derived from a common base
exception, and change the specification of getLargeFileRepository to throw
the base exception.

In LfsProtocolServlet#post, handle the new exceptions and send back the
appropriate HTTP responses as mentioned above.

The specification also mentions several other optional response codes (406,
429, 501, and 509) but these are not implemented in this commit. It should
be trivial to implement them in follow-up commits.

[1] https://github.com/github/git-lfs/blob/master/docs/api/v1/http-v1-batch.md#response-errors

Change-Id: I91be6165bcaf856d0cefc533882330962e2fc9b2
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/LfsProtocolServlet.java
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/errors/LfsException.java [new file with mode: 0644]
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/errors/LfsRepositoryNotFound.java [new file with mode: 0644]
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/errors/LfsRepositoryReadOnly.java [new file with mode: 0644]
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/errors/LfsValidationError.java [new file with mode: 0644]