]> source.dussan.org Git - nextcloud-server.git/commit
Do not write and read rootcerts.crt at the same time 4758/head
authorRoeland Jago Douma <roeland@famdouma.nl>
Tue, 9 May 2017 11:00:07 +0000 (13:00 +0200)
committerRoeland Jago Douma <roeland@famdouma.nl>
Tue, 9 May 2017 11:00:07 +0000 (13:00 +0200)
commit5a61a794d4aefaab05a273a12b509a1585a679d0
treef1f5ff484beaeefba4d05eef651c876ba5c25422
parent46f7e8202fa5f5c2af6ac6e5dcb82be8a5db8f22
Do not write and read rootcerts.crt at the same time

(Possibly) fixes #3470

When updating the main file /files_external/rootcerts.crt we should not
read from /files_external/rootcerts.crt at the same time.

For 2 reasons: writing to a file and reading from it at the same time
can have non deterministic results

And we don't want all the certificates to appear 2 times in there.

This isn't caught by our standard file locking (that does not allow this
actually) because it is in a non locked path....

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
lib/private/Security/CertificateManager.php