]> source.dussan.org Git - gitea.git/commit
Rework markup link rendering (#26745)
authorKN4CK3R <admin@oldschoolhack.me>
Mon, 15 Jan 2024 08:49:24 +0000 (09:49 +0100)
committerGitHub <noreply@github.com>
Mon, 15 Jan 2024 08:49:24 +0000 (08:49 +0000)
commit637451a45ecbc3d127ff2adf27437ce1357493ea
treed1f554b8bfe17bc51a48aacbd4b830906049dae0
parentc7e4629c0245cf6731ea34c2aa6ba4b968ea184a
Rework markup link rendering (#26745)

Fixes #26548

This PR refactors the rendering of markup links. The old code uses
`strings.Replace` to change some urls while the new code uses more
context to decide which link should be generated.

The added tests should ensure the same output for the old and new
behaviour (besides the bug).

We may need to refactor the rendering a bit more to make it clear how
the different helper methods render the input string. There are lots of
options (resolve links / images / mentions / git hashes / emojis / ...)
but you don't really know what helper uses which options. For example,
we currently support images in the user description which should not be
allowed I think:

<details>
  <summary>Profile</summary>

https://try.gitea.io/KN4CK3R

![grafik](https://github.com/go-gitea/gitea/assets/1666336/109ae422-496d-4200-b52e-b3a528f553e5)

</details>

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
42 files changed:
models/issues/comment_code.go
models/repo/repo.go
modules/markup/external/external.go
modules/markup/html.go
modules/markup/html_internal_test.go
modules/markup/html_test.go
modules/markup/markdown/goldmark.go
modules/markup/markdown/markdown.go
modules/markup/markdown/markdown_test.go
modules/markup/orgmode/orgmode.go
modules/markup/orgmode/orgmode_test.go
modules/markup/renderer.go
modules/templates/helper.go
modules/templates/util_render.go
modules/templates/util_render_test.go
routers/common/markup.go
routers/web/feed/convert.go
routers/web/feed/profile.go
routers/web/org/home.go
routers/web/repo/commit.go
routers/web/repo/issue.go
routers/web/repo/milestone.go
routers/web/repo/projects.go
routers/web/repo/release.go
routers/web/repo/render.go
routers/web/repo/view.go
routers/web/repo/wiki.go
routers/web/shared/user/header.go
routers/web/user/home.go
routers/web/user/profile.go
services/mailer/mail.go
services/mailer/mail_release.go
templates/repo/branch/list.tmpl
templates/repo/commit_page.tmpl
templates/repo/commits_list.tmpl
templates/repo/commits_list_small.tmpl
templates/repo/diff/compare.tmpl
templates/repo/graph/commits.tmpl
templates/repo/issue/view_title.tmpl
templates/repo/view_list.tmpl
templates/user/dashboard/feeds.tmpl
tests/fuzz/fuzz_test.go