]> source.dussan.org Git - vaadin-framework.git/commit
projects / vaadin-framework.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: c5abcb0) | patch
Close window on ESC, when maximized button is clicked (#11840) (#11848)
authorAnna Koskinen <Ansku@users.noreply.github.com>
Thu, 19 Dec 2019 08:56:05 +0000 (10:56 +0200)
committerOlli Tietäväinen <ollit@vaadin.com>
Thu, 19 Dec 2019 08:56:05 +0000 (10:56 +0200)
commit6ff8263180966c96d22d49dbcff4b2e2ab5f98e9
tree21c95f94a258cf5648040ed8a574e711faf45229tree | snapshot
parentc5abcb03702a5f82191dc842f443fe82c38ec057commit | diff
Close window on ESC, when maximized button is clicked (#11840) (#11848)

* Close window on ESC, when maximized button is clicked (#11840)

Fixes #11838

Changes:

1. Close a window when maximized button is focused and ESC is pressed
2. Add additional check for a close button to react to the ESC key press
3. Rename a private method `onCloseClick` to `closeWindow` to allow code re-use
client/src/main/java/com/vaadin/client/ui/VWindow.java diff | blob | history
uitest/src/main/java/com/vaadin/tests/components/window/CloseWindowOnEscapeMaximizedButtonFocused.java [new file with mode: 0644] blob
uitest/src/test/java/com/vaadin/tests/components/window/CloseWindowOnEscapeMaximizedButtonFocusedTest.java [new file with mode: 0644] blob
Vaadin 6, 7, 8 is a Java framework for modern Java web applications: https://github.com/vaadin/framework