]> source.dussan.org Git - jgit.git/commit
projects / jgit.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 1f4ab45) | patch
LfsFactory#LfsInputStream: Override int read(byte[], int, int) 15/130215/1
authorDavid Pursehouse <david.pursehouse@gmail.com>
Mon, 1 Oct 2018 02:16:05 +0000 (11:16 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Mon, 1 Oct 2018 02:16:05 +0000 (11:16 +0900)
commit731d638f69f017eb0471888f7a88f661e258e3ba
tree4304f8de10ea110027dd057bcba95f43f8341df8tree | snapshot
parent1f4ab45166d7f89654c0c31418bced44d3d60833commit | diff
LfsFactory#LfsInputStream: Override int read(byte[], int, int)

According to Error Prone, the class should also override:

  int read(byte[], int, int)

otherwise multi-byte reads from this input stream are likely to be slow.

See https://errorprone.info/bugpattern/InputStreamSlowMultibyteRead

Change-Id: I33ab8cd30013447f2a0363b3a7b1424b79cb1818
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
org.eclipse.jgit/src/org/eclipse/jgit/util/LfsFactory.java diff | blob | history
JGit, the Java implementation of git: https://github.com/eclipse-jgit/jgit