]> source.dussan.org Git - vaadin-framework.git/commit
#7930 Eliminate Validator.isValid()
authorHenri Sara <hesara@vaadin.com>
Sat, 12 Nov 2011 10:18:27 +0000 (12:18 +0200)
committerHenri Sara <hesara@vaadin.com>
Sat, 12 Nov 2011 10:18:27 +0000 (12:18 +0200)
commit75924e5597b7c70f15cbe59e73cb250150df53cb
tree19d35950eca09df4fc51e6dc982c8291741ec6c2
parentfe78bbbf534bc67c50ddb8483f568195ea29b645
#7930 Eliminate Validator.isValid()

Eliminate the redundant method Validator.isValid(). Validator.validate()
does the same but throws an exception including the validation error
message.

Migration:
- replace implementations of isValid() with internalIsValid() in custom
subclasses of AbstractValidator
- use Validator.validate() and catch exceptions rather than call
Validator.isValid()
- note that AbstractField still provides an isValid() method that is
internally based on validate()
23 files changed:
src/com/vaadin/data/Validator.java
src/com/vaadin/data/validator/AbstractStringValidator.java
src/com/vaadin/data/validator/AbstractValidator.java
src/com/vaadin/data/validator/CompositeValidator.java
src/com/vaadin/data/validator/NullValidator.java
src/com/vaadin/data/validator/StringLengthValidator.java
src/com/vaadin/ui/AbstractField.java
src/com/vaadin/ui/DateField.java
src/com/vaadin/ui/Form.java
tests/server-side/com/vaadin/tests/server/TestSerialization.java
tests/testbench/com/vaadin/tests/components/datefield/RequiredInvalidDateField.java
tests/testbench/com/vaadin/tests/components/tree/TreeKeyboardNavigationScrolls.java
tests/testbench/com/vaadin/tests/components/tree/TreeKeyboardNavigationValidators.java
tests/testbench/com/vaadin/tests/tickets/Ticket1804.java
tests/testbench/com/vaadin/tests/tickets/Ticket1900.java
tests/testbench/com/vaadin/tests/tickets/Ticket20.java
tests/testbench/com/vaadin/tests/tickets/Ticket2107.java
tests/testbench/com/vaadin/tests/tickets/Ticket2179.java
tests/testbench/com/vaadin/tests/tickets/Ticket2998.java
tests/testbench/com/vaadin/tests/tickets/Ticket736.java
tests/testbench/com/vaadin/tests/tickets/Ticket846.java
tests/testbench/com/vaadin/tests/util/AlwaysFailValidator.java [new file with mode: 0644]
tests/testbench/com/vaadin/tests/validation/EmptyFieldErrorIndicators.java