]> source.dussan.org Git - nextcloud-server.git/commit
Remove deprecated test of internal attributes via assertAttributeEquals in constructo... 21972/head
authorMorris Jobke <hey@morrisjobke.de>
Thu, 23 Jul 2020 11:44:18 +0000 (13:44 +0200)
committerMorris Jobke <hey@morrisjobke.de>
Thu, 23 Jul 2020 15:11:29 +0000 (17:11 +0200)
commit761cdf9877be6d286f96e1f3eb4beab052b89baa
treeab111c79ea60525bbd92dc8f91016b3846d1d3f9
parent1339ea15e26a3db944dcc2255b35d5fd1b0c7549
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests

I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.

See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322

It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
tests/lib/Template/CSSResourceLocatorTest.php
tests/lib/Template/JSResourceLocatorTest.php
tests/lib/Template/ResourceLocatorTest.php