]> source.dussan.org Git - jgit.git/commit
UploadPack: Test filtering by AdvertiseRefsHook in stateless transports 62/134462/3
authorMasaya Suzuki <masayasuzuki@google.com>
Tue, 18 Dec 2018 17:20:54 +0000 (09:20 -0800)
committerMatthias Sohn <matthias.sohn@sap.com>
Mon, 24 Dec 2018 22:51:07 +0000 (23:51 +0100)
commit78b18dbb839b6ff41f199ee338e53610f3fe5be3
tree8cac0fd764e75826b5a5e4ab20633585a167b808
parent3dd3fe9ea495b1b3dec740bbb95076a7aeba0380
UploadPack: Test filtering by AdvertiseRefsHook in stateless transports

AdvertiseRefsHook is used to limit the visibility of the refs in Gerrit.
If this hook is not called, then all refs are treated as visible,
causing the server to serve commits reachable from branches the client
should not be able to access, if asked to via a request naming a guessed
object id.

Until 3a529361a76e8267467071e0b13ebb36b97d8fb2 (Call AdvertiseRefsHook
before validating wants, 2018-12-18), UploadPack would invoke this hook
at ref advertisement time but not during negotiation and when serving a
pack file.  Add a test to avoid regressing. Stateful bidirectional
transports were not affected, so the test uses HTTP.

[jn: split out when backporting the fix to stable-4.5.  The test passes
 as long as v4.9.0.201710071750-r~169 (fetch: Accept any SHA-1 on lhs of
 refspec, 2017-06-04) is cherry picked along with it.]

Change-Id: I8c017107336adc7cb4c826985779676bf043e648
Signed-off-by: Masaya Suzuki <masayasuzuki@google.com>
Signed-off-by: Jonathan Nieder <jrn@google.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit.http.test/META-INF/MANIFEST.MF
org.eclipse.jgit.http.test/pom.xml
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/SmartClientSmartServerTest.java