]> source.dussan.org Git - jgit.git/commit
UploadPack v2 protocol: Stop negotiation for orphan refs 87/189087/6
authorMarcin Czech <maczech@gmail.com>
Wed, 22 Dec 2021 16:42:36 +0000 (17:42 +0100)
committerMarcin Czech <maczech@gmail.com>
Tue, 18 Jan 2022 12:00:03 +0000 (08:00 -0400)
commit78d4fb1ca00149a700f586357139f08efaa29ff6
tree14e3876a4e8021435c3fbcc98078dcf4e5bb39ec
parent8a4b98376785a6c271fede00035fe89dea2b9982
UploadPack v2 protocol: Stop negotiation for orphan refs

The fetch of a single orphan ref (for example Gerrit meta ref:
refs/changes/21/21/meta) did not stop the negotiation so client
had to advertise all refs. This impacts the fetch performance
on repositories with a large number of refs (for example on
Gerrit repository it takes 20 seconds to fetch meta ref
comparing to 1.2 second to fetch ref with parent).

To avoid this issue UploadPack, used on the server side,
now checks if all `want` refs have parents, if not this
means that client doesn't need any extra objects, hence
the server responds with `ready` and finishes the
negotiation phase.

Bug: 577937
Change-Id: Ia3001b400b415d5cf6aae45e72345ca08d3af058
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/UploadPackTest.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/UploadPack.java