]> source.dussan.org Git - jgit.git/commit
HTTP cookies: do tilde expansion on http.cookieFile 49/177649/1
authorThomas Wolf <thomas.wolf@paranor.ch>
Tue, 9 Mar 2021 21:23:14 +0000 (22:23 +0100)
committerThomas Wolf <thomas.wolf@paranor.ch>
Fri, 12 Mar 2021 11:02:22 +0000 (12:02 +0100)
commit808c4495ca941038c087cf6e348b22641db92a5f
tree92d84e7b1746c189dfe231fe00f7740756977123
parent232876421d067a1242e8afcaa33b9171342fee3e
HTTP cookies: do tilde expansion on http.cookieFile

Git config http.cookieFile must have ~ expansion, compare [1].

It also should be an absolute path. While a relative path is allowed,
C git just passes the value on to libcurl, so it'll be relative to the
current working directory and thus not work in all directories.

Log a warning if the path is relative.

(Alternatives would be to throw an exception, or to resolve the path
relative to the .git directory, or relative to the working tree root,
or relative to the config file it occurs in. But C git does not seem
to do either.)

[1] https://github.com/git/git/commit/e5a39ad8e

Bug: 571798
Change-Id: I5cdab6061d0613ac7d8cb7977e5b97f5b88f562d
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
org.eclipse.jgit/resources/org/eclipse/jgit/internal/JGitText.properties
org.eclipse.jgit/src/org/eclipse/jgit/internal/JGitText.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java