]> source.dussan.org Git - gitea.git/commit
Fix tags sort by creation time (descending) on branch/tag dropdowns (#23491)
authorHester Gong <hestergong@gmail.com>
Thu, 16 Mar 2023 17:01:10 +0000 (01:01 +0800)
committerGitHub <noreply@github.com>
Thu, 16 Mar 2023 17:01:10 +0000 (12:01 -0500)
commit8d9f8e10b10bf7c19c1609072a8cb144176ee01b
treedbc431b46826a99536b6401e643e5f5ae4deaf37
parent661e78bed5c0879c32c53eb60f3d6898b93e1f08
Fix tags sort by creation time (descending) on branch/tag dropdowns  (#23491)

This PR fixes the tags sort issue mentioned in #23432
The tags on dropdown shoud be sorted in descending order of time but are
not. Because when getting tags, it execeutes `git tag sort
--sort=-taggerdate`. Git supports two types of tags: lightweight and
annotated, and `git tag sort --sort=-taggerdate` dosen't work with
lightweight tags, which will not give correct result. This PR add
`GetTagNamesByRepoID ` to get tags from the database so the tags are
sorted.

Also adapt this change to the droplist when comparing branches.

Dropdown places:

<img width="369" alt="截屏2023-03-15 14 25 39"
src="https://user-images.githubusercontent.com/17645053/225224506-65a72e50-4c11-41d7-8187-a7e9c7dab2cb.png">

<img width="675" alt="截屏2023-03-15 14 25 27"
src="https://user-images.githubusercontent.com/17645053/225224526-65ce8008-340c-43f6-aa65-b6bd9e1a1bf1.png">
models/repo/release.go
modules/context/repo.go
routers/web/repo/compare.go