]> source.dussan.org Git - vaadin-framework.git/commit
Colorpicker validation handling (#10821)
authorKatriHaapalinna <katri@vaadin.com>
Thu, 19 Apr 2018 12:03:16 +0000 (15:03 +0300)
committerTeemu Suo-Anttila <tsuoanttila@users.noreply.github.com>
Fri, 20 Apr 2018 12:19:23 +0000 (15:19 +0300)
commita10e72c67aef3ff6cc6760b68ede57b2606b7a37
tree2629db6a4c879ec7a450b3d68a1c3f22917d6ee7
parentca232caaf03dd764023e34e9576acc944cd1a9c3
Colorpicker validation handling (#10821)

* ColorTextField, helper methods, and regex for validating and handling text input

* Refactored structure to avoid creating new component for validation

* Style to adapt to error indicator

* Tests for validating input in ColorPickerPreview component's TextField

* Merge branch 'master' into colorpicker_validation

* Fix path to server class

* Fix test: Submit the new value

* Fix test: ignore Phantom JS

* Fix hsl+hsla validation patterns to accept '%', test value tweaking

* Merge branch 'master' of github.com:vaadin/framework into colorpicker_validation

* Fix: remove warning when color is updated from elsewhere

* Revisions: input validation only once, Logging level WARN

* Revisions: unit tests for color pattern matching

* Revisions: moved parsing to utility class, tests for parsing all accepted input formats

* Fixed import in tests, comments

* Revisions: Logger as constant, ignore utility class in serialization test

* Corner case tests

* Revisions: protected method for parsing error text, fix to test

* Revisions: NPE fix
12 files changed:
server/src/main/java/com/vaadin/ui/components/colorpicker/ColorPickerPreview.java
server/src/main/java/com/vaadin/ui/components/colorpicker/ColorUtil.java [new file with mode: 0644]
server/src/test/java/com/vaadin/tests/server/ClassesSerializableTest.java
server/src/test/java/com/vaadin/tests/server/component/colorpicker/HSLAPatternParsingTest.java [new file with mode: 0644]
server/src/test/java/com/vaadin/tests/server/component/colorpicker/HSLPatternParsingTest.java [new file with mode: 0644]
server/src/test/java/com/vaadin/tests/server/component/colorpicker/HexPatternParsingTest.java [new file with mode: 0644]
server/src/test/java/com/vaadin/tests/server/component/colorpicker/RGBAPatternParsingTest.java [new file with mode: 0644]
server/src/test/java/com/vaadin/tests/server/component/colorpicker/RGBPatternParsingTest.java [new file with mode: 0644]
testbench-api/src/main/java/com/vaadin/testbench/elements/ColorPickerPreviewElement.java
themes/src/main/themes/VAADIN/themes/valo/components/_colorpicker.scss
uitest/src/main/java/com/vaadin/tests/components/colorpicker/ValoColorPickerTestUI.java [new file with mode: 0644]
uitest/src/test/java/com/vaadin/tests/components/colorpicker/ValoColorPickerInputFormatsTest.java [new file with mode: 0644]