]> source.dussan.org Git - gitea.git/commit
projects / gitea.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5ccf8b6) | patch
Fix race in LFS ContentStore.Put(...) (#14895)
authorzeripath <art27@cantab.net>
Sat, 6 Mar 2021 20:21:56 +0000 (20:21 +0000)
committerGitHub <noreply@github.com>
Sat, 6 Mar 2021 20:21:56 +0000 (20:21 +0000)
commita68db9076aa47f3464df62edaf35808b428d7c59
treeee3ff1af21e89513d352c5b68b620d6196069239tree | snapshot
parent5ccf8b64306fd6d695e6938fea7ad2f85df5717ccommit | diff
Fix race in LFS ContentStore.Put(...) (#14895)

Continuing on from #14888

The previous implementation has race whereby an incomplete upload or
hash mismatch upload can end up in the ContentStore. This PR moves the
validation into the reader so that if there is a hash error or size
mismatch the reader will return with an error instead of an io.EOF
causing the storage to abort the storage.

Signed-off-by: Andrew Thornton <art27@cantab.net>
modules/lfs/content_store.go diff | blob | history
Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD: https://github.com/go-gitea/gitea