]> source.dussan.org Git - gitea.git/commit
Fix nil checking on typed interface (#17598)
authorGusted <williamzijl7@hotmail.com>
Mon, 15 Nov 2021 13:16:11 +0000 (13:16 +0000)
committerGitHub <noreply@github.com>
Mon, 15 Nov 2021 13:16:11 +0000 (21:16 +0800)
commitab1379743e812eb1430e4d15a00c3f7b9e759da6
tree81dfccc630574b917035842431b4d0e7c938a100
parent253d9e415813e90543cca8d94112c9e4238d39a4
Fix nil checking on typed interface (#17598)

* Fix nil checking on typed interface

- Partially resoles #17596
- Resolves SA4023 errors.
- Ensure correctly that typed interface are nil.

* Remove unnecessary code

`NewBleveIndexer` will never return nil, even on errors.

* Patch `NewBleveIndexer`

* Fix low-level functions

* Remove deadcode

* Fix GetSession

* Close Elastic search when err isn't nil

* Update elastic_search.go

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
modules/indexer/code/bleve.go
modules/indexer/code/elastic_search.go
modules/indexer/code/indexer.go
routers/web/base.go