]> source.dussan.org Git - gitea.git/commit
Fix gitea-origin-url with default ports (#29085)
authorsilverwind <me@silverwind.io>
Thu, 8 Feb 2024 02:37:09 +0000 (03:37 +0100)
committerGitHub <noreply@github.com>
Thu, 8 Feb 2024 02:37:09 +0000 (02:37 +0000)
commitb6bf8041d8e8ee845728687b1f358f1d482afff2
tree85e8359535c8b66be0f26a780577f55bfb4eb7ac
parenta4859dcfea0cf1c7818f3cb2dcbb6b83902cc9d5
Fix gitea-origin-url with default ports (#29085)

When setting `url.host` on a URL object with no port specified (like is
the case of default port), the resulting URL's port will not change.
Workaround this quirk in the URL standard by explicitely setting port
for the http and https protocols.

Extracted the logic to a function for the purpose of testing. Initially
I wanted to have the function in utils.js, but it turns out esbuild can
not treeshake the unused functions which would result in the
webcomponents chunk having all 2kB utils.js inlined, so it seemed not
worth.

Fixes: https://github.com/go-gitea/gitea/issues/29084
.eslintrc.yaml
web_src/js/webcomponents/GiteaOriginUrl.js
web_src/js/webcomponents/GiteaOriginUrl.test.js [new file with mode: 0644]