]> source.dussan.org Git - nextcloud-server.git/commit
Let users configure security headers in their Webserver
authorLukas Reschke <lukas@owncloud.com>
Mon, 19 Jan 2015 10:56:04 +0000 (11:56 +0100)
committerLukas Reschke <lukas@owncloud.com>
Mon, 2 Mar 2015 18:07:46 +0000 (19:07 +0100)
commitbbd5f2841561911461d992483cab54f5c18fa342
tree113e9ab1919c8fb42a7fd90db79139b783a643c9
parent1155ad6e389e47e110a415f22eddda1570dc9ff2
Let users configure security headers in their Webserver

Doing this in the PHP code is not the right approach for multiple reasons:

1. A bug in the PHP code prevents them from being added to the response.
2. They are only added when something is served via PHP and not in other cases (that makes for example the newest IE UXSS which is not yet patched by Microsoft exploitable on ownCloud)
3. Some headers such as the Strict-Transport-Security might require custom modifications by administrators. This was not possible before and lead to buggy situations.

This pull request moves those headers out of the PHP code and adds a security check to the admin settings performed via JS.
17 files changed:
.htaccess
config/config.sample.php
core/js/core.json
core/js/js.js
core/js/setupchecks.js
core/js/tests/specs/setupchecksSpec.js [new file with mode: 0644]
lib/base.php
lib/private/appframework/app.php
lib/private/appframework/http/request.php
lib/private/response.php
lib/private/user/session.php
settings/admin.php
settings/controller/securitysettingscontroller.php
settings/js/admin.js
settings/routes.php
settings/templates/admin.php
tests/settings/controller/securitysettingscontrollertest.php