]> source.dussan.org Git - vaadin-framework.git/commit
Partly eliminate the use of Property.toString().
authorHenri Sara <hesara@vaadin.com>
Mon, 7 Nov 2011 15:54:18 +0000 (17:54 +0200)
committerHenri Sara <hesara@vaadin.com>
Mon, 7 Nov 2011 15:54:18 +0000 (17:54 +0200)
commitc93efdf86d84ae42e67f344ad5fdd13e197f952a
treeac74b5b541dc37ff97b5eb638b5956999d00e415
parentb7dc0286b82ee10fb7ac991d88040afe157f74a4
Partly eliminate the use of Property.toString().

The toString() method should not be used on a property to get its value.
Added getStringValue() to AbstractField, Label etc. Using them
where applicable. Added comments to some problematic locations where
Property.toString() is known to be used.

AbstractField.toString() and Label.toString() still return the same
values as before, but it will throw an exception in future revisions.

Migration needed: Replace explicit and implicit uses of
Property.toString() with use property.getValue() and its
string representation.
Alternatively, use AbstractProperty.getStringValue() and
AbstractField.getStringValue() instead of Property.toString() during
migration.
26 files changed:
src/com/vaadin/data/Property.java
src/com/vaadin/data/util/AbstractProperty.java
src/com/vaadin/data/util/IndexedContainer.java
src/com/vaadin/data/util/PropertyFormatter.java
src/com/vaadin/data/util/PropertysetItem.java
src/com/vaadin/data/util/filter/SimpleStringFilter.java
src/com/vaadin/data/util/sqlcontainer/ColumnProperty.java
src/com/vaadin/data/util/sqlcontainer/RowItem.java
src/com/vaadin/ui/AbstractField.java
src/com/vaadin/ui/AbstractTextField.java
src/com/vaadin/ui/Label.java
src/com/vaadin/ui/ProgressIndicator.java
src/com/vaadin/ui/RichTextArea.java
src/com/vaadin/ui/Table.java
tests/server-side/com/vaadin/data/util/PropertySetItemTest.java
tests/server-side/com/vaadin/data/util/sqlcontainer/SQLContainerTest.java
tests/server-side/com/vaadin/tests/server/TestSerialization.java
tests/testbench/com/vaadin/tests/TestForContainerFilterable.java
tests/testbench/com/vaadin/tests/TestForPreconfiguredComponents.java
tests/testbench/com/vaadin/tests/TestForTrees.java
tests/testbench/com/vaadin/tests/components/datefield/DefaultHandleUnparsableDateField.java
tests/testbench/com/vaadin/tests/components/textfield/TextChangeEventsWithNonImmediateValueChange.java
tests/testbench/com/vaadin/tests/dd/DDTest2.java
tests/testbench/com/vaadin/tests/tickets/Ticket1397.java
tests/testbench/com/vaadin/tests/tickets/Ticket2053.java
tests/testbench/com/vaadin/tests/tickets/Ticket2090.java