]> source.dussan.org Git - gitea.git/commit
Add more linters to improve code readability (#19989)
authorWim <wim@42.be>
Mon, 20 Jun 2022 10:02:49 +0000 (12:02 +0200)
committerGitHub <noreply@github.com>
Mon, 20 Jun 2022 10:02:49 +0000 (12:02 +0200)
commitcb50375e2b6abf0c79d4891e5e1ea775b9759cd2
tree938af0f442baf79cebd114692aff5ad6af37f987
parent3289abcefc563d6ea16c1dbd19680b874a58a6d3
Add more linters to improve code readability (#19989)

Add nakedret, unconvert, wastedassign, stylecheck and nolintlint linters to improve code readability

- nakedret - https://github.com/alexkohler/nakedret - nakedret is a Go static analysis tool to find naked returns in functions greater than a specified function length.
- unconvert - https://github.com/mdempsky/unconvert - Remove unnecessary type conversions
- wastedassign - https://github.com/sanposhiho/wastedassign -  wastedassign finds wasted assignment statements.
- notlintlint -  Reports ill-formed or insufficient nolint directives
- stylecheck - https://staticcheck.io/docs/checks/#ST - keep style consistent
  - excluded: [ST1003 - Poorly chosen identifier](https://staticcheck.io/docs/checks/#ST1003) and [ST1005 - Incorrectly formatted error string](https://staticcheck.io/docs/checks/#ST1005)
147 files changed:
.golangci.yml
cmd/hook.go
integrations/api_issue_stopwatch_test.go
integrations/api_packages_container_test.go
integrations/editor_test.go
integrations/git_test.go
integrations/integration_test.go
integrations/nonascii_branches_test.go
integrations/oauth_test.go
integrations/repo_fork_test.go
integrations/repo_generate_test.go
integrations/user_test.go
models/action.go
models/admin/notice.go
models/asymkey/gpg_key_commit_verification.go
models/asymkey/ssh_key_test.go
models/auth/oauth2.go
models/db/engine.go
models/db/index.go
models/db/list_options.go
models/db/sql_postgres_with_schema.go
models/git/branches.go
models/git/commit_status.go
models/issues/assignees.go
models/issues/comment.go
models/issues/issue.go
models/issues/issue_project.go
models/issues/issue_watch.go
models/issues/issue_xref.go
models/issues/pull.go
models/issues/review.go
models/issues/stopwatch.go
models/issues/tracked_time.go
models/migrations/v143.go
models/migrations/v180.go
models/migrations/v189.go
models/notification.go
models/organization/team.go
models/packages/package_version.go
models/perm/access/repo_permission.go
models/project/issue.go
models/release.go
models/repo.go
models/repo/archiver.go
models/repo/repo.go
models/statistic.go
models/unit/unit.go
models/user/search.go
models/webhook/hooktask.go
modules/activitypub/client.go
modules/activitypub/user_settings.go
modules/base/natural_sort.go
modules/charset/charset_test.go
modules/charset/escape.go
modules/context/api.go
modules/context/private.go
modules/context/repo.go
modules/context/utils.go
modules/convert/convert.go
modules/convert/issue.go
modules/doctor/fix16961.go
modules/eventsource/event.go
modules/git/batch_reader.go
modules/git/blob_nogogit.go
modules/git/commit.go
modules/git/commit_info_nogogit.go
modules/git/diff.go
modules/git/pipeline/lfs_nogogit.go
modules/git/repo_attribute.go
modules/git/repo_base_nogogit.go
modules/git/repo_branch_nogogit.go
modules/git/repo_compare.go
modules/git/repo_compare_test.go
modules/git/repo_index.go
modules/git/repo_tag_nogogit.go
modules/git/sha1_nogogit.go
modules/git/signature_nogogit.go
modules/git/utils.go
modules/gitgraph/graph_test.go
modules/graceful/context.go
modules/highlight/highlight.go
modules/indexer/code/bleve.go
modules/indexer/code/elastic_search.go
modules/markup/common/footnote.go
modules/markup/markdown/markdown.go
modules/markup/orgmode/orgmode.go
modules/markup/sanitizer_test.go
modules/migration/issue.go
modules/nosql/manager.go
modules/nosql/manager_leveldb.go
modules/nosql/manager_redis.go
modules/packages/multi_hasher.go
modules/process/manager.go
modules/process/manager_stacktraces.go
modules/queue/helper.go
modules/queue/queue_bytefifo.go
modules/queue/queue_disk_channel.go
modules/queue/unique_queue_disk_channel.go
modules/references/references.go
modules/repository/hooks.go
modules/setting/database.go
modules/setting/federation.go
modules/setting/i18n.go
modules/setting/log.go
modules/setting/service.go
modules/storage/storage.go
modules/structs/org_type.go
modules/templates/helper.go
modules/templates/helper_test.go
modules/timeutil/since.go
modules/timeutil/timestamp.go
modules/util/io.go
modules/web/wrap_convert.go
routers/api/v1/activitypub/reqsignature.go
routers/api/v1/notify/notifications.go
routers/api/v1/org/org.go
routers/api/v1/repo/file.go
routers/api/v1/repo/issue_label.go
routers/api/v1/repo/status.go
routers/api/v1/utils/hook.go
routers/private/hook_pre_receive.go
routers/private/manager_process.go
routers/private/serv.go
routers/web/admin/repos.go
routers/web/auth/oauth.go
routers/web/feed/convert.go
routers/web/repo/branch.go
routers/web/repo/download.go
routers/web/repo/editor_test.go
routers/web/repo/projects.go
routers/web/repo/view.go
routers/web/user/setting/profile.go
routers/web/web.go
services/agit/agit.go
services/auth/source/ldap/source_search.go
services/auth/sspi_windows.go
services/automerge/automerge.go
services/gitdiff/gitdiff.go
services/issue/assignee.go
services/issue/issue.go
services/mailer/mail.go
services/mailer/mail_test.go
services/migrations/onedev.go
services/pull/merge.go
services/pull/review.go
services/task/migrate.go
services/webhook/webhook.go