]> source.dussan.org Git - gitea.git/commit
Fix a bug returning 404 when display a single tag with no release (#29466)
authorLunny Xiao <xiaolunwen@gmail.com>
Sat, 2 Mar 2024 14:03:39 +0000 (22:03 +0800)
committerGitHub <noreply@github.com>
Sat, 2 Mar 2024 14:03:39 +0000 (14:03 +0000)
commitcc27b50bdf9d1e2b02c91d7c4d338e01408e8522
tree5cc97201cdd4ec0f267fc5035fb020c41bdaeb40
parent423372d84ab3d885e47d4a00cd69d6040b61cc4c
Fix a bug returning 404 when display a single tag with no release (#29466)

Partially caused by #29149

When use

```go
releases, err := getReleaseInfos(ctx, &repo_model.FindReleasesOptions{
ListOptions: db.ListOptions{Page: 1, PageSize: 1},
RepoID:      ctx.Repo.Repository.ID,
TagNames:    []string{ctx.Params("*")},
// only show draft releases for users who can write, read-only users shouldn't see draft releases.
IncludeDrafts: writeAccess,
})
```
replace
```go
release, err := repo_model.GetRelease(ctx, ctx.Repo.Repository.ID, ctx.Params("*"))
```
It missed `IncludeTags: true,`. That means this bug will be occupied only when the release is a tag.
This PR will fix

 - Get the right tag record when it's not a release
 - Display correct tag tab but not release tag when it's a tag.
- The button will bring the tag name to the new page when it's a single tag page
- the new page will automatically hide the release target inputbox when the tag name is pre filled. This should be backport to v1.21.
routers/web/repo/release.go
templates/repo/release/list.tmpl
templates/repo/release_tag_header.tmpl
tests/integration/links_test.go
web_src/js/features/repo-release.js