]> source.dussan.org Git - gitblit.git/commit
Define manager interfaces and update all of Gitblit to use managers
authorJames Moger <james.moger@gitblit.com>
Sun, 17 Nov 2013 21:15:24 +0000 (16:15 -0500)
committerJames Moger <james.moger@gitblit.com>
Tue, 26 Nov 2013 21:07:04 +0000 (16:07 -0500)
commitdb4f6b5740c6ea45d9e2209dc569bc18904a8b4d
tree8dd6c651876359ea2d66e844b77af29394f8cd1e
parent99d0d4fd66f3490b61c700065b7d16bc4e73f226
Define manager interfaces and update all of Gitblit to use managers

These manager interfaces define how the GitBlit singleton will
eventually be split into smaller component managers.  The Wicket app and
all servlets have been updated to request the needed managers.  There
are _very_ few method signature changes - although there are a handful.

This is a surgical sharding of responsibility based on a proof of
concept refactor.  Instead of random references to  GittBlit.self()
there are now precise references to the manager interface required to
accomplish some task.  Some tasks may require references to multiple
managers.

The code is now littered with calls to GitBlit.getManager(class) and
those familiar with the code-base will no doubt notice the duplication
of methods from IUserService in IUserManager and the addition of
implementation methods in the GitBlit context class.  When the
GitBlit class is broken apart and the existing external authentication
user service classes are refactored to AuthenticationService classes,
this will again simplify and flatten.  But in order to safely and
cleanly modularize the stable code-base we will have to live with a
little duplication for a short while.

Change-Id: I7314ec8acaab2dcc6092785ed4434cc09fdbbe16
97 files changed:
src/main/java/com/gitblit/AccessRestrictionFilter.java
src/main/java/com/gitblit/AuthenticationFilter.java
src/main/java/com/gitblit/BranchGraphServlet.java
src/main/java/com/gitblit/DownloadZipServlet.java
src/main/java/com/gitblit/EnforceAuthenticationFilter.java
src/main/java/com/gitblit/FederationClient.java
src/main/java/com/gitblit/FederationPullExecutor.java
src/main/java/com/gitblit/FederationServlet.java
src/main/java/com/gitblit/GCExecutor.java
src/main/java/com/gitblit/GitBlit.java
src/main/java/com/gitblit/GitBlitServer.java
src/main/java/com/gitblit/GitFilter.java
src/main/java/com/gitblit/GitblitUserService.java
src/main/java/com/gitblit/HtpasswdUserService.java
src/main/java/com/gitblit/IStoredSettings.java
src/main/java/com/gitblit/LdapUserService.java
src/main/java/com/gitblit/LogoServlet.java
src/main/java/com/gitblit/LuceneExecutor.java
src/main/java/com/gitblit/MirrorExecutor.java
src/main/java/com/gitblit/PAMUserService.java
src/main/java/com/gitblit/PagesFilter.java
src/main/java/com/gitblit/PagesServlet.java
src/main/java/com/gitblit/RedmineUserService.java
src/main/java/com/gitblit/RobotsTxtServlet.java
src/main/java/com/gitblit/RpcFilter.java
src/main/java/com/gitblit/RpcServlet.java
src/main/java/com/gitblit/SalesforceUserService.java
src/main/java/com/gitblit/SparkleShareInviteServlet.java
src/main/java/com/gitblit/SyndicationFilter.java
src/main/java/com/gitblit/SyndicationServlet.java
src/main/java/com/gitblit/WindowsUserService.java
src/main/java/com/gitblit/git/GitServlet.java
src/main/java/com/gitblit/git/GitblitReceivePack.java
src/main/java/com/gitblit/git/GitblitReceivePackFactory.java
src/main/java/com/gitblit/git/GitblitUploadPackFactory.java
src/main/java/com/gitblit/git/RepositoryResolver.java
src/main/java/com/gitblit/manager/IFederationManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/IGitblitManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/INotificationManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/IProjectManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/IRepositoryManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/IRuntimeManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/ISessionManager.java [new file with mode: 0644]
src/main/java/com/gitblit/manager/IUserManager.java [new file with mode: 0644]
src/main/java/com/gitblit/utils/ActivityUtils.java
src/main/java/com/gitblit/wicket/GitBlitWebApp.java
src/main/java/com/gitblit/wicket/GitblitWicketFilter.java
src/main/java/com/gitblit/wicket/pages/ActivityPage.java
src/main/java/com/gitblit/wicket/pages/ChangePasswordPage.java
src/main/java/com/gitblit/wicket/pages/EditRepositoryPage.java
src/main/java/com/gitblit/wicket/pages/EditTeamPage.java
src/main/java/com/gitblit/wicket/pages/EditUserPage.java
src/main/java/com/gitblit/wicket/pages/EmptyRepositoryPage.java
src/main/java/com/gitblit/wicket/pages/LogoutPage.java
src/main/java/com/gitblit/wicket/pages/RepositoryPage.java
src/main/java/com/gitblit/wicket/pages/RootPage.java
src/main/java/com/gitblit/wicket/pages/SessionPage.java
src/test/java/com/gitblit/tests/ActivityTest.java
src/test/java/com/gitblit/tests/ArrayUtilsTest.java
src/test/java/com/gitblit/tests/Base64Test.java
src/test/java/com/gitblit/tests/ByteFormatTest.java
src/test/java/com/gitblit/tests/DiffUtilsTest.java
src/test/java/com/gitblit/tests/FanoutServiceTest.java
src/test/java/com/gitblit/tests/FederationTests.java
src/test/java/com/gitblit/tests/FileUtilsTest.java
src/test/java/com/gitblit/tests/GitBlitSuite.java
src/test/java/com/gitblit/tests/GitBlitTest.java
src/test/java/com/gitblit/tests/GitDaemonStopTest.java
src/test/java/com/gitblit/tests/GitDaemonTest.java
src/test/java/com/gitblit/tests/GitServletTest.java
src/test/java/com/gitblit/tests/GitblitUnitTest.java [new file with mode: 0644]
src/test/java/com/gitblit/tests/GroovyScriptTest.java
src/test/java/com/gitblit/tests/HtpasswdUserServiceTest.java
src/test/java/com/gitblit/tests/Issue0259Test.java
src/test/java/com/gitblit/tests/Issue0271Test.java
src/test/java/com/gitblit/tests/JGitUtilsTest.java
src/test/java/com/gitblit/tests/JnaUtilsTest.java
src/test/java/com/gitblit/tests/JsonUtilsTest.java
src/test/java/com/gitblit/tests/LdapUserServiceTest.java
src/test/java/com/gitblit/tests/LuceneExecutorTest.java
src/test/java/com/gitblit/tests/MailTest.java
src/test/java/com/gitblit/tests/MarkdownUtilsTest.java
src/test/java/com/gitblit/tests/MetricUtilsTest.java
src/test/java/com/gitblit/tests/ModelUtilsTest.java
src/test/java/com/gitblit/tests/ObjectCacheTest.java
src/test/java/com/gitblit/tests/PermissionsTest.java
src/test/java/com/gitblit/tests/PushLogTest.java
src/test/java/com/gitblit/tests/RedmineUserServiceTest.java
src/test/java/com/gitblit/tests/RepositoryModelTest.java
src/test/java/com/gitblit/tests/RpcTests.java
src/test/java/com/gitblit/tests/StringUtilsTest.java
src/test/java/com/gitblit/tests/SyndicationUtilsTest.java
src/test/java/com/gitblit/tests/TimeUtilsTest.java
src/test/java/com/gitblit/tests/UserServiceTest.java
src/test/java/com/gitblit/tests/X509UtilsTest.java
src/test/java/de/akquinet/devops/GitBlit4UITests.java
src/test/java/de/akquinet/devops/GitBlitServer4UITests.java