]> source.dussan.org Git - vaadin-framework.git/commit
Refactor how DataCommunicator passes filters to its DataProvider (#8309)
authorLeif Åstrand <legioth@gmail.com>
Wed, 25 Jan 2017 07:44:16 +0000 (09:44 +0200)
committerGitHub <noreply@github.com>
Wed, 25 Jan 2017 07:44:16 +0000 (09:44 +0200)
commite397ea01e5ddb0c977561c008b84c6ed7c0ef706
treef67be4b1efc51bd6a885ba9ebc7d81740d076acc
parent6c6161caeb8d4524aba11fa7976366981e090e85
Refactor how DataCommunicator passes filters to its DataProvider (#8309)

The immediate benefit of this change is that ComboBox doesn't have to do
any wrapping when a ListDataProvider is set. A secondary benefit is that
a bunch of redundant type parameters and unsafe casts can be removed.

This is one of many steps towards #8245
server/src/main/java/com/vaadin/data/HasFilterableDataProvider.java
server/src/main/java/com/vaadin/data/provider/DataCommunicator.java
server/src/main/java/com/vaadin/ui/AbstractListing.java
server/src/main/java/com/vaadin/ui/AbstractSingleSelect.java
server/src/main/java/com/vaadin/ui/ComboBox.java
server/src/main/java/com/vaadin/ui/components/grid/MultiSelectionModelImpl.java
server/src/test/java/com/vaadin/data/provider/DataCommunicatorTest.java
server/src/test/java/com/vaadin/data/provider/ReplaceDataProviderTest.java
server/src/test/java/com/vaadin/tests/server/component/combobox/ComboBoxFilteringTest.java