]> source.dussan.org Git - nextcloud-server.git/commit
Fix disabling send password by Talk without new password in mail shares
authorDaniel Calviño Sánchez <danxuliu@gmail.com>
Thu, 28 May 2020 18:40:33 +0000 (20:40 +0200)
committerbackportbot[bot] <backportbot[bot]@users.noreply.github.com>
Fri, 29 May 2020 19:38:28 +0000 (19:38 +0000)
commitfb271d6b81b1f23945f9c610be7ef259f291b612
tree736f9abeeeaa05680e18b9de9c1add94ada6d1d2
parent6e19f53173ed8524e1bbb13a9ede36865fd24636
Fix disabling send password by Talk without new password in mail shares

When "send password by Talk" was disabled in a mail share it was
possible to keep the same password as before, as it does not pose any
security issue (unlike keeping it when "send password by Talk" is
enabled, as in that case the password was already disclosed by mail).

However, if a mail share is updated but the password is not set again
only the hashed password will be available. In that case it would not
make sense to send the password by mail, so now the password must be
changed when disabling "send password by Talk".

Note that, even if explicitly setting the same password again along with
the "send password by Talk" property would work, this was also prevented
for simplicity.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
lib/private/Share20/Manager.php
tests/lib/Share20/ManagerTest.php