]> source.dussan.org Git - jgit.git/commit
projects / jgit.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 55371c5) | patch
Fix BadComparable error flagged by error prone 01/163401/4
authorDavid Ostrovsky <david@ostrovsky.org>
Fri, 22 May 2020 05:49:49 +0000 (07:49 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Mon, 1 Jun 2020 22:56:32 +0000 (18:56 -0400)
commit3e2ec7e5e81a489a326d872aa0670119ff2c1152
treef81c4dbd5bf8db0543810396a85eeb18516cf034tree | snapshot
parent55371c5f063370aeca85acab16f867734ff4226ccommit | diff
Fix BadComparable error flagged by error prone

Running recent error prone version complaining on that code:

LfsPointer.java:171: error: [BadComparable] Possible sign flip from
narrowing conversion
return (int) (getSize() - o.getSize());
       ^
    (see https://errorprone.info/bugpattern/BadComparable)
  Did you mean 'return Long.compare(getSize(), o.getSize());'?

Bug: 562756
Change-Id: I0522f1025319a9290c448a064fbafdb4b16d1d59
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/LfsPointer.java diff | blob | history
JGit, the Java implementation of git: https://github.com/eclipse-jgit/jgit