]> source.dussan.org Git - jgit.git/commit
projects / jgit.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 762f621) | patch
Enable and fix "Statement unnecessarily nested within else clause" warnings 03/151203/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Thu, 17 Oct 2019 00:01:25 +0000 (09:01 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Thu, 17 Oct 2019 01:20:14 +0000 (10:20 +0900)
commit98cdca9b5a830f1c2ceca52379d662a68109d43e
treed843141173394b4ea4e435553885749096d4fb79tree | snapshot
parent762f6212b4692b28f098ac597058bd6a489b8b49commit | diff
Enable and fix "Statement unnecessarily nested within else clause" warnings

Since [1] the gerrit project includes jgit as a submodule, and has this
warning enabled, resulting in 100s of warnings in the console.

Also enable the warning here, and fix them.

At the same time, add missing braces around adjacent and nearby one-line
blocks.

[1] https://gerrit-review.googlesource.com/c/gerrit/+/227897

Change-Id: I81df3fc7ed6eedf6874ce1a3bedfa727a1897e4c
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
122 files changed:
org.eclipse.jgit.ant.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.ant/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.archive/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.http.apache/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.http.server/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/glue/ServletBinderImpl.java diff | blob | history
org.eclipse.jgit.http.server/src/org/eclipse/jgit/http/server/resolver/DefaultUploadPackFactory.java diff | blob | history
org.eclipse.jgit.http.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/SmartClientSmartServerTest.java diff | blob | history
org.eclipse.jgit.junit.http/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.junit.http/src/org/eclipse/jgit/junit/http/AppServer.java diff | blob | history
org.eclipse.jgit.junit.ssh/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.junit/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.junit/src/org/eclipse/jgit/junit/TestRepository.java diff | blob | history
org.eclipse.jgit.lfs.server.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.lfs.server/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/fs/FileLfsRepository.java diff | blob | history
org.eclipse.jgit.lfs.server/src/org/eclipse/jgit/lfs/server/s3/SignerV4.java diff | blob | history
org.eclipse.jgit.lfs.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.lfs/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/BuiltinLFS.java diff | blob | history
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/CleanFilter.java diff | blob | history
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/internal/LfsConnectionFactory.java diff | blob | history
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/lib/AnyLongObjectId.java diff | blob | history
org.eclipse.jgit.pgm.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.pgm/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.pgm/src/org/eclipse/jgit/console/ConsoleCredentialsProvider.java diff | blob | history
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Status.java diff | blob | history
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/RebuildCommitGraph.java diff | blob | history
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/debug/TextHashFunctions.java diff | blob | history
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/opt/CmdLineParser.java diff | blob | history
org.eclipse.jgit.ssh.apache.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.ssh.apache/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/JGitClientSession.java diff | blob | history
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/OpenSshServerKeyDatabase.java diff | blob | history
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/proxy/HttpParser.java diff | blob | history
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/internal/transport/sshd/proxy/Socks5ClientConnector.java diff | blob | history
org.eclipse.jgit.ssh.apache/src/org/eclipse/jgit/transport/sshd/SshdSession.java diff | blob | history
org.eclipse.jgit.test/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit.test/tst/org/eclipse/jgit/internal/storage/file/PackFileSnapshotTest.java diff | blob | history
org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/ObjectIdSerializerTest.java diff | blob | history
org.eclipse.jgit.test/tst/org/eclipse/jgit/lib/RefDatabaseConflictingNamesTest.java diff | blob | history
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/HttpAuthTest.java diff | blob | history
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/WalkEncryptionTest.java diff | blob | history
org.eclipse.jgit.ui/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit/.settings/org.eclipse.jdt.core.prefs diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/BlameCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/DiffCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/FetchCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/GarbageCollectCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/MergeCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/PullCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/RebaseCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/ResetCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/api/SubmoduleSyncCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/blame/BlameResult.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/diff/DiffFormatter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/diff/Edit.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/diff/RawText.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheCheckout.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCacheEntry.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/fnmatch/AbstractHead.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/fnmatch/FileNameMatcher.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/ManifestParser.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoCommand.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/gitrepo/RepoProject.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/ignore/internal/PathMatcher.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/ignore/internal/Strings.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/ketch/LagCheck.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/dfs/DfsRefDatabase.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/FileRepository.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/GcLog.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/ObjectDirectoryInserter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/PackFile.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectory.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/RefDirectoryUpdate.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/ReflogEntryImpl.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/UnpackedObject.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/file/UnpackedObjectCache.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/pack/PackWriter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/reftable/ReftableDatabase.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/reftree/RefTreeBatch.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/transport/http/NetscapeCookieFileCache.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/internal/transport/ssh/OpenSshConfigFile.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/AnyObjectId.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/BaseRepositoryBuilder.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/BranchConfig.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/Config.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/DefaultTypedConfigGetter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/IndexDiff.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/ObjectReader.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/lib/Repository.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/merge/MergeConfig.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/merge/MergeMessageFormatter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/merge/ResolveMerger.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/merge/ThreeWayMerger.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/notes/FanoutBucket.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/notes/LeafBucket.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/notes/NoteMap.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/notes/NoteMapMerger.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/notes/NoteParser.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotWalk.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/TreeRevFilter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/BaseReceivePack.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/CredentialsProviderUserInfo.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/HMACSHA1NonceGenerator.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/RemoteConfig.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/Transport.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/URIish.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/transport/resolver/FileResolver.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/FileTreeIterator.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/WorkingTreeIterator.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/IndexDiffFilter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathSuffixFilter.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/ChangeIdUtil.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/FS.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/IO.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/RefMap.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/SshSupport.java diff | blob | history
org.eclipse.jgit/src/org/eclipse/jgit/util/io/LimitedInputStream.java diff | blob | history
JGit, the Java implementation of git: https://github.com/eclipse-jgit/jgit