]> source.dussan.org Git - jgit.git/commit
Cleanup: message reporting for HTTP redirect handling 14/103514/1
authorThomas Wolf <thomas.wolf@paranor.ch>
Wed, 23 Aug 2017 09:50:05 +0000 (11:50 +0200)
committerThomas Wolf <thomas.wolf@paranor.ch>
Wed, 23 Aug 2017 10:20:55 +0000 (12:20 +0200)
commit1b4daa2994a16bad5b9b77b24d8ce1f1d25f78fa
treef1454afe768b7cfb705d323b635572b73325f337
parent7ac1bfc834fe65b7e86e8f54f1f5025df90f8a92
Cleanup: message reporting for HTTP redirect handling

The addition of "tooManyRedirects" in commit 7ac1bfc ("Do
authentication re-tries on HTTP POST") was an error I didn't
catch after rebasing that change. That message had been renamed
in the earlier commit e17bfc9 ("Add support to follow HTTP
redirects") to "redirectLimitExceeded".

Also make sure we always use the TransportException(URIish, ...)
constructor; it'll prefix the message given with the sanitized URI.
Change messages to remove the explicit mention of that URI inside the
message. Adapt tests that check the expected exception message text.

For the info logging of redirects, remove a potentially present
password component in the URI to avoid leaking it into the log.

Change-Id: I517112404757a9a947e92aaace743c6541dce6aa
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
org.eclipse.jgit.http.test/tst/org/eclipse/jgit/http/test/SmartClientSmartServerTest.java
org.eclipse.jgit/resources/org/eclipse/jgit/internal/JGitText.properties
org.eclipse.jgit/src/org/eclipse/jgit/internal/JGitText.java
org.eclipse.jgit/src/org/eclipse/jgit/transport/TransportHttp.java