]> source.dussan.org Git - jgit.git/commit
ErrorProne: Enable check for misuse of ExpectedException 44/126144/2
authorDavid Pursehouse <david.pursehouse@gmail.com>
Tue, 17 Jul 2018 01:43:04 +0000 (10:43 +0900)
committerDavid Pursehouse <david.pursehouse@gmail.com>
Mon, 23 Jul 2018 06:14:00 +0000 (07:14 +0100)
commit4c29736a3e1d4fb94f11c424488b831a1f062e0b
treebcc0928fc54dd4aba8b775e9df886b34cf024de8
parent280707b0fc717fdd8898242f21589f0c7c7d87be
ErrorProne: Enable check for misuse of ExpectedException

Any additional statements after the statement that is expected to
throw will never be executed in a passing test. This can lead to
inappropriately passing tests where later incorrect assertions are
skipped by the thrown exception. See [1] for examples.

There are no cases of this in the code base, but by enabling the
checker with severity ERROR we can ensure that we don't overlook
any future misuse of ExpectedException.

[1] http://errorprone.info/bugpattern/ExpectedExceptionChecker

Change-Id: I266d4f73f6075bfc1e39fa3d8aee7dee96db61b9
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
pom.xml