]> source.dussan.org Git - jgit.git/commit
Fix PlotCommitList to set lanes on child-less commits 80/1580/5
authorChristian Halstrick <christian.halstrick@sap.com>
Tue, 14 Sep 2010 16:19:44 +0000 (18:19 +0200)
committerMatthias Sohn <matthias.sohn@sap.com>
Tue, 14 Sep 2010 16:19:44 +0000 (18:19 +0200)
commit2dc031ad9b82cadf5b3b47db9107a3fce28a7540
treedd5ffeed127b929a52f83ca0f871ac689d72da80
parentdb1a9c6a8cc1f157cd08369160e52ec8f81bf4e3
Fix PlotCommitList to set lanes on child-less commits

In PlotCommitList.enter() commits are positioned on lanes for visual
presentation. This implementation was buggy: commits without
children (often the starting points for the RevWalk) are not positioned
on separate lanes.

The problem was that when handling commits with multiple children
(that's where branches fork out) it was not handled that some of the
children may not have been positioned on a lane yet. I fixed that and
added a number of tests which specifically test the layout of commits
on lanes.

Bug: 300282
Bug: 320263
Change-Id: I267b97ecccb5251cec54cec90207e075ab50503e
Signed-off-by: Christian Halstrick <christian.halstrick@sap.com>
Signed-off-by: Matthias Sohn <matthias.sohn@sap.com>
org.eclipse.jgit.test/tst/org/eclipse/jgit/revplot/PlotCommitListTest.java [new file with mode: 0644]
org.eclipse.jgit/src/org/eclipse/jgit/revplot/PlotCommitList.java