]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fix VOverlay animation-out jitter
authorJouni Koivuviita <jouni@vaadin.com>
Fri, 13 Jun 2014 07:23:19 +0000 (10:23 +0300)
committerJouni Koivuviita <jouni@vaadin.com>
Wed, 18 Jun 2014 07:55:47 +0000 (07:55 +0000)
An improper fix to an issue with the closing animation that was left
there mistakenly.

Change-Id: I645c6983058fb128cf060a3c7bb2766cb47e3a81

client/src/com/vaadin/client/ui/VOverlay.java

index 1d653a8ff5c0d8bdbff586172326c4e0eb68cff7..a4f62775e1418d144aed1e94654009bd614daa02 100644 (file)
@@ -978,7 +978,6 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
                         });
             } else {
                 // Check if animations are used
-                setVisible(false);
                 addStyleDependentName(ADDITIONAL_CLASSNAME_ANIMATE_OUT);
                 if (isShadowEnabled()) {
                     shadow.addClassName(CLASSNAME_SHADOW + "-"
@@ -989,7 +988,6 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
                 if (animationName == null) {
                     animationName = "";
                 }
-                setVisible(true);
 
                 if (animationName.contains(ADDITIONAL_CLASSNAME_ANIMATE_OUT)) {
                     // Disable GWT PopupPanel closing animation if used