]> source.dussan.org Git - poi.git/commitdiff
OLD_FILES, EXPECTED_FAILURES, and IGNORED do not need to be modified when executing...
authorJaven O'Neal <onealj@apache.org>
Thu, 16 Feb 2017 06:15:13 +0000 (06:15 +0000)
committerJaven O'Neal <onealj@apache.org>
Thu, 16 Feb 2017 06:15:13 +0000 (06:15 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1783174 13f79535-47bb-0310-9956-ffa450edef68

src/integrationtest/org/apache/poi/TestAllFiles.java

index c11d41500ef5780c6fb1229c5f54ef4dc4530c95..af30e69efd8f9fa89fa8e313e673df3b3d0633ae 100644 (file)
@@ -177,12 +177,15 @@ public class TestAllFiles {
         HANDLERS.put("spreadsheet/test_properties1", new NullFileHandler());
     }
 
+    private static final Set<String> unmodifiableHashSet(String... a) {
+        return Collections.unmodifiableSet(hashSet(a));
+    }
     private static final Set<String> hashSet(String... a) {
         return new HashSet<String>(Arrays.asList(a));
     }
 
     // Old Word Documents where we can at least extract some text
-    private static final Set<String> OLD_FILES = hashSet(
+    private static final Set<String> OLD_FILES = unmodifiableHashSet(
         "document/Bug49933.doc",
         "document/Bug51944.doc",
         "document/Word6.doc",
@@ -194,7 +197,7 @@ public class TestAllFiles {
         "document/52117.doc"
     );
 
-    private static final Set<String> EXPECTED_FAILURES = hashSet(
+    private static final Set<String> EXPECTED_FAILURES = unmodifiableHashSet(
         // password protected files
         "spreadsheet/password.xls",
         "spreadsheet/protected_passtika.xlsx",
@@ -284,7 +287,7 @@ public class TestAllFiles {
         "spreadsheet/ConditionalFormattingSamples.xls"
     );
 
-    private static final Set<String> IGNORED = hashSet(
+    private static final Set<String> IGNORED = unmodifiableHashSet(
         // need JDK8+ - https://bugs.openjdk.java.net/browse/JDK-8038081
         "slideshow/42474-2.ppt",
         // OPC handler works / XSSF handler fails