]> source.dussan.org Git - vaadin-framework.git/commitdiff
Fixes "add first row" action (#13334)
authorHenrik Paul <henrik@vaadin.com>
Tue, 26 Aug 2014 11:39:48 +0000 (14:39 +0300)
committerHenrik Paul <henrik@vaadin.com>
Tue, 26 Aug 2014 11:39:48 +0000 (14:39 +0300)
Change-Id: I23e2dcbf5d7e0801ae63e02126eee8e85726eefc

uitest/src/com/vaadin/tests/components/grid/basicfeatures/GridBasicFeatures.java

index d54b1838ea8d402035c826021c737f8765e66446..a862aa095f497df3dee29a54882baa88f1dc71f6 100644 (file)
@@ -561,10 +561,28 @@ public class GridBasicFeatures extends AbstractComponentTest<Grid> {
                     public void execute(Grid c, String value, Object data) {
                         Item item = ds.addItemAt(0, new Object());
                         for (int i = 0; i < COLUMNS; i++) {
-                            item.getItemProperty(getColumnProperty(i))
-                                    .setValue("newcell: " + i);
+                            Class<?> type = ds.getType(getColumnProperty(i));
+                            if (String.class.isAssignableFrom(type)) {
+                                Property<String> itemProperty = getProperty(
+                                        item, i);
+                                itemProperty.setValue("newcell: " + i);
+                            } else if (Integer.class.isAssignableFrom(type)) {
+                                Property<Integer> itemProperty = getProperty(
+                                        item, i);
+                                itemProperty.setValue(Integer.valueOf(i));
+                            } else {
+                                // let the default value be taken implicitly.
+                            }
                         }
                     }
+
+                    private <T extends Object> Property<T> getProperty(
+                            Item item, int i) {
+                        @SuppressWarnings("unchecked")
+                        Property<T> itemProperty = item
+                                .getItemProperty(getColumnProperty(i));
+                        return itemProperty;
+                    }
                 }, null);
 
         createClickAction("Remove first row", "Body rows",