]> source.dussan.org Git - sonarqube.git/commitdiff
Fix quality flaw
authorJulien Lancelot <julien.lancelot@gmail.com>
Wed, 19 Jun 2013 06:38:35 +0000 (08:38 +0200)
committerJulien Lancelot <julien.lancelot@gmail.com>
Wed, 19 Jun 2013 06:38:35 +0000 (08:38 +0200)
sonar-core/src/main/java/org/sonar/core/issue/db/IssueFilterDto.java
sonar-server/src/main/java/org/sonar/server/issue/IssueFilterService.java

index 5a831c285fad5215e2a6668f80186cd3956c8ad4..2ffb02da287f72755eb4daf4888a0f61eeb21dde 100644 (file)
@@ -66,11 +66,11 @@ public class IssueFilterDto {
     return this;
   }
 
-  public Boolean isShared() {
+  public boolean isShared() {
     return shared;
   }
 
-  public IssueFilterDto setShared(@Nullable Boolean shared) {
+  public IssueFilterDto setShared(boolean shared) {
     this.shared = shared;
     return this;
   }
index ae455c438ffabbb96ecf250c86baab333c604ad8..594e8c9fa40884bd5e5e9feaea5d8e1347a9fbdb 100644 (file)
@@ -161,7 +161,7 @@ public class IssueFilterService implements ServerComponent {
   }
 
   private void verifyLoggedIn(UserSession userSession) {
-    if (!userSession.isLoggedIn() || userSession.login() == null) {
+    if (!userSession.isLoggedIn() && userSession.login() != null) {
       throw new IllegalStateException("User is not logged in");
     }
   }