]> source.dussan.org Git - rspamd.git/commitdiff
Check gsize against G_MAXSIZE not ULLONG_MAX 3603/head
authorChristian Göttsche <cgzones@googlemail.com>
Sat, 9 Jan 2021 13:25:46 +0000 (14:25 +0100)
committerChristian Göttsche <cgzones@googlemail.com>
Sat, 9 Jan 2021 13:25:46 +0000 (14:25 +0100)
/builds/cgzones/rspamd/debian/output/source_dir/src/libserver/http/http_message.c: In function 'rspamd_http_message_set_body':
/builds/cgzones/rspamd/debian/output/source_dir/src/libserver/http/http_message.c:201:23: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  201 |   if (len != 0 && len != ULLONG_MAX) {
      |                       ^~
/builds/cgzones/rspamd/debian/output/source_dir/src/libserver/http/http_message.c:230:23: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  230 |   if (len != 0 && len != ULLONG_MAX) {
      |                       ^~

src/libserver/http/http_message.c

index 5f9d221789e807c995494173783a26e98234584a..e68778f3e08d2e2a8ee3e3fd76b235151a68f921 100644 (file)
@@ -198,7 +198,7 @@ rspamd_http_message_set_body (struct rspamd_http_message *msg,
                        return FALSE;
                }
 
-               if (len != 0 && len != ULLONG_MAX) {
+               if (len != 0 && len != G_MAXSIZE) {
                        if (ftruncate (storage->shared.shm_fd, len) == -1) {
                                return FALSE;
                        }
@@ -227,7 +227,7 @@ rspamd_http_message_set_body (struct rspamd_http_message *msg,
                }
        }
        else {
-               if (len != 0 && len != ULLONG_MAX) {
+               if (len != 0 && len != G_MAXSIZE) {
                        if (data == NULL) {
                                storage->normal = rspamd_fstring_sized_new (len);
                                msg->body_buf.len = 0;