]> source.dussan.org Git - poi.git/commitdiff
junit improvements: assertEquals(null|true|false, ...) -> assertNull, assertTrue...
authorJaven O'Neal <onealj@apache.org>
Thu, 5 Jan 2017 11:26:42 +0000 (11:26 +0000)
committerJaven O'Neal <onealj@apache.org>
Thu, 5 Jan 2017 11:26:42 +0000 (11:26 +0000)
git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1777450 13f79535-47bb-0310-9956-ffa450edef68

src/scratchpad/testcases/org/apache/poi/hsmf/TestBasics.java

index 7cdfdb1989f7dbf611a2515a37abde697d3a2bdc..da66a9b800e8b2d70c9bbd7bce8319af10e14cad 100644 (file)
@@ -127,7 +127,7 @@ public final class TestBasics extends TestCase {
     * Use a file with no HTML body
     */
    public void testMissingChunks() throws Exception {
-      assertEquals(false, attachments.isReturnNullOnMissingChunk());
+      assertFalse(attachments.isReturnNullOnMissingChunk());
 
       try {
           attachments.getHtmlBody();
@@ -138,7 +138,7 @@ public final class TestBasics extends TestCase {
 
       attachments.setReturnNullOnMissingChunk(true);
 
-      assertEquals(null, attachments.getHtmlBody());
+      assertNull(attachments.getHtmlBody());
           
       attachments.setReturnNullOnMissingChunk(false);
       
@@ -155,7 +155,7 @@ public final class TestBasics extends TestCase {
     *  missing recipient email address
     */
    public void testMissingAddressChunk() throws Exception {
-      assertEquals(false, noRecipientAddress.isReturnNullOnMissingChunk());
+      assertFalse(noRecipientAddress.isReturnNullOnMissingChunk());
 
       try {
          noRecipientAddress.getRecipientEmailAddress();
@@ -176,7 +176,7 @@ public final class TestBasics extends TestCase {
       noRecipientAddress.getRecipientEmailAddressList();
       assertEquals("", noRecipientAddress.getRecipientEmailAddress());
       assertEquals(1, noRecipientAddress.getRecipientEmailAddressList().length);
-      assertEquals(null, noRecipientAddress.getRecipientEmailAddressList()[0]);
+      assertNull(noRecipientAddress.getRecipientEmailAddressList()[0]);
       
       // Check a few other bits too
       assertEquals("Microsoft Outlook 2003 Team", noRecipientAddress.getDisplayFrom());
@@ -189,10 +189,10 @@ public final class TestBasics extends TestCase {
     * Test the 7 bit detection
     */
    public void test7BitDetection() throws Exception {
-      assertEquals(false, unicode.has7BitEncodingStrings());
-      assertEquals(true, simple.has7BitEncodingStrings());
-      assertEquals(true, chinese.has7BitEncodingStrings());
-      assertEquals(true, cyrillic.has7BitEncodingStrings());
+      assertFalse(unicode.has7BitEncodingStrings());
+      assertTrue(simple.has7BitEncodingStrings());
+      assertTrue(chinese.has7BitEncodingStrings());
+      assertTrue(cyrillic.has7BitEncodingStrings());
    }
        
    /**