import org.sonar.api.BatchExtension;
import org.sonar.api.CoreProperties;
import org.sonar.api.batch.ProjectClasspath;
+import org.sonar.api.batch.maven.MavenPlugin;
+import org.sonar.api.batch.maven.MavenUtils;
import org.sonar.api.profiles.RulesProfile;
import org.sonar.api.resources.Project;
+import org.sonar.api.utils.Logs;
import org.sonar.api.utils.SonarException;
import org.sonar.plugins.findbugs.xml.ClassFilter;
import org.sonar.plugins.findbugs.xml.FindBugsFilter;
}
public edu.umd.cs.findbugs.Project getFindbugsProject() {
+ if (project.getReuseExistingRulesConfig()) {
+ Logs.INFO.warn("Reusing existing Findbugs configuration is deprecated as it's unstable and can not provide meaningful results. This feature will be removed soon.");
+ }
+
File classesDir = project.getFileSystem().getBuildOutputDir();
if (classesDir == null || !classesDir.exists()) {
throw new SonarException("Findbugs needs sources to be compiled. "
return findbugsProject;
}
- public File saveIncludeConfigXml() throws IOException {
+ private MavenPlugin getFindbugsMavenPlugin() {
+ return MavenPlugin.getPlugin(project.getPom(), MavenUtils.GROUP_ID_CODEHAUS_MOJO, "findbugs-maven-plugin");
+ }
+
+ public String saveIncludeConfigXml() throws IOException {
+ if (project.getReuseExistingRulesConfig()) {
+ return getFindbugsMavenPlugin().getParameter("includeFilterFile");
+ }
StringWriter conf = new StringWriter();
exporter.exportProfile(profile, conf);
- return project.getFileSystem().writeToWorkingDirectory(conf.toString(), "findbugs-include.xml");
+ return project.getFileSystem().writeToWorkingDirectory(conf.toString(), "findbugs-include.xml").getAbsolutePath();
}
- public File saveExcludeConfigXml() throws IOException {
+ public String saveExcludeConfigXml() throws IOException {
+ if (project.getReuseExistingRulesConfig()) {
+ return getFindbugsMavenPlugin().getParameter("excludeFilterFile");
+ }
FindBugsFilter findBugsFilter = new FindBugsFilter();
if (project.getExclusionPatterns() != null) {
for (String exclusion : project.getExclusionPatterns()) {
findBugsFilter.addMatch(new Match(classFilter));
}
}
- return project.getFileSystem().writeToWorkingDirectory(findBugsFilter.toXml(), "findbugs-exclude.xml");
+ return project.getFileSystem().writeToWorkingDirectory(findBugsFilter.toXml(), "findbugs-exclude.xml").getAbsolutePath();
}
public String getEffort() {
import org.sonar.api.utils.SonarException;
import org.sonar.api.utils.TimeProfiler;
-import edu.umd.cs.findbugs.*;
+import edu.umd.cs.findbugs.Detector;
+import edu.umd.cs.findbugs.DetectorFactoryCollection;
+import edu.umd.cs.findbugs.FindBugs;
+import edu.umd.cs.findbugs.FindBugs2;
+import edu.umd.cs.findbugs.Project;
+import edu.umd.cs.findbugs.XMLBugReporter;
import edu.umd.cs.findbugs.config.UserPreferences;
import java.io.File;
userPreferences.setEffort(configuration.getEffort());
engine.setUserPreferences(userPreferences);
- engine.addFilter(configuration.saveIncludeConfigXml().getAbsolutePath(), true);
- engine.addFilter(configuration.saveExcludeConfigXml().getAbsolutePath(), false);
+ engine.addFilter(configuration.saveIncludeConfigXml(), true);
+ engine.addFilter(configuration.saveExcludeConfigXml(), false);
engine.setDetectorFactoryCollection(DetectorFactoryCollection.instance());
engine.setAnalysisFeatureSettings(FindBugs.DEFAULT_EFFORT);
engine.finishSettings();
Executors.newSingleThreadExecutor()
- .submit(new FindbugsTask(engine))
- .get(configuration.getTimeout(), TimeUnit.MILLISECONDS);
+ .submit(new FindbugsTask(engine))
+ .get(configuration.getTimeout(), TimeUnit.MILLISECONDS);
profiler.stop();
return xmlReport;
public boolean shouldExecuteOnProject(Project project) {
return project.getFileSystem().hasJavaSourceFiles()
- && !profile.getActiveRulesByRepository(FindbugsConstants.REPOSITORY_KEY).isEmpty()
+ && ( !profile.getActiveRulesByRepository(FindbugsConstants.REPOSITORY_KEY).isEmpty() || project.getReuseExistingRulesConfig())
&& project.getPom() != null && !StringUtils.equalsIgnoreCase(project.getPom().getPackaging(), "ear");
}
package org.sonar.plugins.findbugs;
+import static org.hamcrest.core.Is.is;
+import static org.junit.Assert.assertThat;
+import static org.junit.internal.matchers.StringContains.containsString;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
import org.apache.commons.io.FileUtils;
import org.junit.Test;
import org.sonar.api.utils.SonarException;
import java.io.File;
-import static org.hamcrest.core.Is.is;
-import static org.junit.Assert.assertThat;
-import static org.junit.internal.matchers.StringContains.containsString;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-
public class FindbugsExecutorTest {
@Test
project.addSourceDir(new File("test-resources/src").getCanonicalPath());
project.setCurrentWorkingDirectory(new File("test-resources"));
when(conf.getFindbugsProject()).thenReturn(project);
- when(conf.saveExcludeConfigXml()).thenReturn(new File("test-resources/findbugs-exclude.xml"));
- when(conf.saveIncludeConfigXml()).thenReturn(new File("test-resources/findbugs-include.xml"));
+ when(conf.saveExcludeConfigXml()).thenReturn(new File("test-resources/findbugs-exclude.xml").getAbsolutePath());
+ when(conf.saveIncludeConfigXml()).thenReturn(new File("test-resources/findbugs-include.xml").getAbsolutePath());
when(conf.getEffort()).thenReturn("default");
when(conf.getTimeout()).thenReturn(FindbugsConstants.FINDBUGS_TIMEOUT_DEFAULT_VALUE);
return conf;