==================================================================== */
package org.apache.poi.xssf.usermodel;
+import org.apache.poi.hssf.record.formula.Ptg;
+import org.apache.poi.ss.formula.FormulaParser;
+import org.apache.poi.ss.formula.FormulaType;
import org.apache.poi.ss.usermodel.Name;
import org.apache.poi.ss.util.AreaReference;
-import org.apache.poi.util.POILogFactory;
-import org.apache.poi.util.POILogger;
import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTDefinedName;
/**
* @deprecated (Nov 2008) Misleading name. Use {@link #setFormula(String)} instead.
*/
public void setReference(String ref){
- setFormula(ref);
+ setFormula(ref);
}
/**
* Returns the reference of this named range, such as Sales!C20:C30.
* @throws IllegalArgumentException if the specified reference is unparsable
*/
public void setFormula(String formulaText) {
- // TODO parse formula and throw IllegalArgumentException if problem
+ XSSFEvaluationWorkbook fpb = XSSFEvaluationWorkbook.create(workbook);
+ Ptg[] ptgs;
+ try {
+ ptgs = FormulaParser.parse(formulaText, fpb, FormulaType.CELL); // TODO - use type NAMEDRANGE
+ } catch (RuntimeException e) {
+ if (e.getClass().getName().startsWith(FormulaParser.class.getName())) {
+ throw new IllegalArgumentException("Unparsable formula '" + formulaText + "'");
+ }
+ throw e;
+ }
ctName.setStringValue(formulaText);
}
public static Test suite() {
TestSuite result = new TestSuite(AllXSSFUsermodelTests.class.getName());
- result.addTestSuite(TestXSSFBorder.class);
- result.addTestSuite(TestXSSFBugs.class);
- result.addTestSuite(TestXSSFCellFill.class);
- result.addTestSuite(TestXSSFHeaderFooter.class);
- result.addTestSuite(TestXSSFSheetComments.class);
- result.addTestSuite(TestColumnHelper.class);
- result.addTestSuite(TestHeaderFooterHelper.class);
result.addTestSuite(TestFormulaEvaluatorOnXSSF.class);
+ result.addTestSuite(TestSheetHiding.class);
+ result.addTestSuite(TestXSSFBugs.class);
result.addTestSuite(TestXSSFCell.class);
result.addTestSuite(TestXSSFCellStyle.class);
result.addTestSuite(TestXSSFComment.class);
result.addTestSuite(TestXSSFDialogSheet.class);
+ result.addTestSuite(TestXSSFDrawing.class);
+ result.addTestSuite(TestXSSFFont.class);
result.addTestSuite(TestXSSFFormulaEvaluation.class);
result.addTestSuite(TestXSSFHeaderFooter.class);
+ result.addTestSuite(TestXSSFHyperlink.class);
+ result.addTestSuite(TestXSSFName.class);
+ result.addTestSuite(TestXSSFPicture.class);
+ result.addTestSuite(TestXSSFPictureData.class);
+ result.addTestSuite(TestXSSFPrintSetup.class);
+ result.addTestSuite(TestXSSFRichTextString.class);
result.addTestSuite(TestXSSFRow.class);
result.addTestSuite(TestXSSFSheet.class);
result.addTestSuite(TestXSSFWorkbook.class);
-
- result.addTestSuite(TestXSSFFont.class);
- result.addTestSuite(TestXSSFPrintSetup.class);
+
+ result.addTestSuite(TestXSSFBorder.class);
+ result.addTestSuite(TestXSSFCellFill.class);
+ result.addTestSuite(TestXSSFSheetComments.class);
+
+ result.addTestSuite(TestColumnHelper.class);
+ result.addTestSuite(TestHeaderFooterHelper.class);
return result;
}
assertEquals(ref1, name1.getReference());\r
assertEquals("Test1", name1.getSheetName());\r
\r
- String ref2 = "Testing Named Ranges!$A$1:$B$1";\r
+ String ref2 = "'Testing Named Ranges'!$A$1:$B$1";\r
name1.setReference(ref2);\r
//XSSFName#setReference stores the reference in canonical form and puts the sheet name in single quotes\r
assertEquals("'Testing Named Ranges'!$A$1:$B$1", name1.getReference());\r