Fix quality flaws

diff --git a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueChangeDtoTest.java b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueChangeDtoTest.java
index 10dba57cd7fc98cd05e56280ce93540000ebbed0..408ced20c9d089d105c647df053bece5e4d3788c 100644 (file)
--- a/sonar-core/src/test/java/org/sonar/core/issue/db/IssueChangeDtoTest.java
+++ b/sonar-core/src/test/java/org/sonar/core/issue/db/IssueChangeDtoTest.java
@@ -61,21 +61,15 @@ public class IssueChangeDtoTest {
   }
 
   @Test
-  public void create_from_diff_without_date() throws Exception {
+  public void to_comment() throws Exception {
     FieldDiffs diffs = new FieldDiffs();
     diffs.setDiff("severity", "INFO", "BLOCKER");
     diffs.setUserLogin("emmerik");
     diffs.setCreationDate(null);
 
-    IssueChangeDto dto = IssueChangeDto.of("ABCDE", diffs);
+    DefaultIssueComment comment = IssueChangeDto.of("ABCDE", diffs).toComment();
+
 
-    assertThat(dto.getChangeData()).isEqualTo("severity=INFO|BLOCKER");
-    assertThat(dto.getChangeType()).isEqualTo("diff");
-    assertThat(dto.getCreatedAt()).isNotNull();
-    assertThat(dto.getUpdatedAt()).isNotNull();
-    assertThat(dto.getIssueChangeCreationDate()).isNull();
-    assertThat(dto.getIssueKey()).isEqualTo("ABCDE");
-    assertThat(dto.getUserLogin()).isEqualTo("emmerik");
   }
 
   @Test

diff --git a/sonar-server/src/main/java/org/sonar/server/rule/RuleDocumentParser.java b/sonar-server/src/main/java/org/sonar/server/rule/RuleDocumentParser.java
index e9d9846ba471f2a3956a8a9a12689db0b9006c13..a2c2d46c1a3c9dbd5ebea97079f18a7bc8228f59 100644 (file)
--- a/sonar-server/src/main/java/org/sonar/server/rule/RuleDocumentParser.java
+++ b/sonar-server/src/main/java/org/sonar/server/rule/RuleDocumentParser.java
@@ -33,7 +33,7 @@ import static com.google.common.collect.Lists.newArrayList;
 
 public class RuleDocumentParser {
 
-  private void RuleDocumentParser() {
+  private RuleDocumentParser() {
     // Utility class
   }