Prevent nil pointer in GetPullRequestCommitStatusState (#10342)

Ensure that pr.HeadRepo is loaded before using it in GetPullRequestCommitStatusState.

Fixes error on merging with successful commit merge statuses.

diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go
index 77aca485562f87bceb6827dab630ecba55ea74b6..a4803bfb9fecfb3735997c8f196f3ee4dcb320a4 100644 (file)
--- a/services/pull/commit_status.go
+++ b/services/pull/commit_status.go
@@ -91,6 +91,11 @@ func IsPullCommitStatusPass(pr *models.PullRequest) (bool, error) {
 
 // GetPullRequestCommitStatusState returns pull request merged commit status state
 func GetPullRequestCommitStatusState(pr *models.PullRequest) (structs.CommitStatusState, error) {
+       // Ensure HeadRepo is loaded
+       if err := pr.LoadHeadRepo(); err != nil {
+               return "", errors.Wrap(err, "LoadHeadRepo")
+       }
+
        // check if all required status checks are successful
        headGitRepo, err := git.OpenRepository(pr.HeadRepo.RepoPath())
        if err != nil {