--- /dev/null
+/*
+ * Copyright 2000-2013 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.components.combobox;
+
+import com.vaadin.server.VaadinRequest;
+import com.vaadin.tests.components.AbstractTestUI;
+import com.vaadin.ui.Button;
+import com.vaadin.ui.ComboBox;
+
+/**
+ * Test UI for issue #13488, where scrolling to the next page with pagelength 0
+ * would break the rendering of any page except the first.
+ *
+ * @author Vaadin Ltd
+ */
+@SuppressWarnings("serial")
+public class ComboboxPageLengthZeroScroll extends AbstractTestUI {
+
+ @Override
+ protected void setup(VaadinRequest request) {
+ ComboBox combobox = new ComboBox("New items enabled:");
+ combobox.setPageLength(0);
+
+ for (int i = 0; i++ < 10;) {
+ combobox.addItem("1 AMERICAN SAMOA " + i);
+ combobox.addItem("ANTIGUA AND BARBUDA " + i);
+ }
+
+ getLayout().addComponent(combobox);
+ getLayout().addComponent(new Button("dummy"));
+ }
+
+ @Override
+ protected String getTestDescription() {
+ return "Scrolling with pagelength == 0 previously resulted in broken style, should be fixed now";
+ }
+
+ @Override
+ protected Integer getTicketNumber() {
+ return 13488;
+ }
+
+}
--- /dev/null
+/*
+ * Copyright 2000-2014 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.components.combobox;
+
+import org.junit.Assert;
+import org.junit.Test;
+import org.openqa.selenium.By;
+import org.openqa.selenium.Keys;
+import org.openqa.selenium.WebElement;
+import org.openqa.selenium.interactions.Actions;
+
+import com.vaadin.tests.tb3.MultiBrowserTest;
+
+/**
+ * Test class for testing issue #13488 - changing pages with pagelength=0 breaks
+ * the style.
+ *
+ * @author Vaadin Ltd
+ */
+
+public class ComboboxPageLengthZeroScrollTest extends MultiBrowserTest {
+ @Test
+ public void testComboboxPageLength() {
+ openTestURL();
+
+ WebElement comboBox = vaadinElement("/VVerticalLayout[0]/Slot[1]/VVerticalLayout[0]/Slot[0]/VFilterSelect[0]#textbox");
+
+ // navigate to the next page. keyboard navigation is the preferred
+ // method here since it's much easier to implement.
+
+ Actions keyNavigation = new Actions(driver).moveToElement(comboBox)
+ .click();
+
+ for (int i = 0; i < 25; ++i) {
+ keyNavigation.sendKeys(Keys.ARROW_DOWN);
+
+ }
+ keyNavigation.perform();
+
+ // The broken behavior always caused a v-shadow element to have
+ // height: 10px. Verify that this does no longer happen.
+
+ String cssValue = driver.findElement(By.className("v-shadow"))
+ .getCssValue("height");
+
+ Assert.assertNotEquals("v-shadow height should not be 10px", "10px",
+ cssValue);
+
+ }
+}
--- /dev/null
+/*
+ * Copyright 2000-2014 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.components.combobox;
+
+import com.vaadin.server.VaadinRequest;
+import com.vaadin.tests.components.AbstractTestUIWithLog;
+import com.vaadin.ui.Button;
+import com.vaadin.ui.Button.ClickEvent;
+import com.vaadin.ui.ComboBox;
+
+/**
+ * Test UI for adding a stylename to a combobox with an undefined width.
+ *
+ * @author Vaadin Ltd
+ */
+public class ComboboxStyleChangeWidth extends AbstractTestUIWithLog {
+
+ @Override
+ protected void setup(VaadinRequest request) {
+ final ComboBox cbFoo = new ComboBox();
+ cbFoo.setImmediate(true);
+ cbFoo.setSizeUndefined();
+ cbFoo.addItem("A really long string that causes an inline width to be set");
+
+ Button btn = new Button("Click to break CB",
+ new Button.ClickListener() {
+ @Override
+ public void buttonClick(ClickEvent event) {
+ cbFoo.addStyleName("foofoo");
+
+ }
+ });
+
+ addComponent(cbFoo);
+ addComponent(btn);
+
+ }
+
+ @Override
+ protected String getTestDescription() {
+ return "The computed inline width of an undefined-width ComboBox "
+ + "(with a sufficiently long option string) breaks when "
+ + "the component's stylename is changed after initial "
+ + "rendering.";
+ }
+
+ @Override
+ protected Integer getTicketNumber() {
+ return Integer.valueOf(13444);
+ }
+
+}
--- /dev/null
+/*
+ * Copyright 2000-2014 Vaadin Ltd.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.vaadin.tests.components.combobox;
+
+import static org.junit.Assert.assertEquals;
+
+import org.junit.Test;
+
+import com.vaadin.testbench.elements.ButtonElement;
+import com.vaadin.testbench.elements.ComboBoxElement;
+import com.vaadin.tests.tb3.MultiBrowserTest;
+
+/**
+ * Tests that changing a stylename will not cause the width parameter to be
+ * removed from a combobox.
+ *
+ * @author Vaadin Ltd
+ */
+
+public class ComboboxStyleChangeWidthTest extends MultiBrowserTest {
+
+ @Test
+ public void testWidthRetained() {
+ openTestURL();
+
+ ComboBoxElement comboBox = $(ComboBoxElement.class).first();
+ String oldStyle = comboBox.getAttribute("style");
+
+ ButtonElement button = $(ButtonElement.class).first();
+ button.click();
+ String newStyle = comboBox.getAttribute("style");
+
+ assertEquals("width has changed, should remain equal", oldStyle,
+ newStyle);
+
+ }
+
+}
+++ /dev/null
-/*
- * Copyright 2000-2013 Vaadin Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.vaadin.tests.components.ui;
-
-import com.vaadin.server.VaadinRequest;
-import com.vaadin.tests.components.AbstractTestUI;
-import com.vaadin.ui.Button;
-import com.vaadin.ui.ComboBox;
-
-/**
- * Test UI for issue #13488, where scrolling to the next page with pagelength 0
- * would break the rendering of any page except the first.
- *
- * @author Vaadin Ltd
- */
-@SuppressWarnings("serial")
-public class ComboboxPageLengthZeroScroll extends AbstractTestUI {
-
- @Override
- protected void setup(VaadinRequest request) {
- ComboBox combobox = new ComboBox("New items enabled:");
- combobox.setPageLength(0);
-
- for (int i = 0; i++ < 10;) {
- combobox.addItem("1 AMERICAN SAMOA " + i);
- combobox.addItem("ANTIGUA AND BARBUDA " + i);
- }
-
- getLayout().addComponent(combobox);
- getLayout().addComponent(new Button("dummy"));
- }
-
- @Override
- protected String getTestDescription() {
- return "Scrolling with pagelength == 0 previously resulted in broken style, should be fixed now";
- }
-
- @Override
- protected Integer getTicketNumber() {
- return 13488;
- }
-
-}
+++ /dev/null
-/*
- * Copyright 2000-2014 Vaadin Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.vaadin.tests.components.ui;
-
-import org.junit.Assert;
-import org.junit.Test;
-import org.openqa.selenium.By;
-import org.openqa.selenium.Keys;
-import org.openqa.selenium.WebElement;
-import org.openqa.selenium.interactions.Actions;
-
-import com.vaadin.tests.tb3.MultiBrowserTest;
-
-/**
- * Test class for testing issue #13488 - changing pages with pagelength=0 breaks
- * the style.
- *
- * @author Vaadin Ltd
- */
-
-public class ComboboxPageLengthZeroScrollTest extends MultiBrowserTest {
- @Test
- public void testComboboxPageLength() {
- openTestURL();
-
- WebElement comboBox = vaadinElement("/VVerticalLayout[0]/Slot[1]/VVerticalLayout[0]/Slot[0]/VFilterSelect[0]#textbox");
-
- // navigate to the next page. keyboard navigation is the preferred
- // method here since it's much easier to implement.
-
- Actions keyNavigation = new Actions(driver).moveToElement(comboBox)
- .click();
-
- for (int i = 0; i < 25; ++i) {
- keyNavigation.sendKeys(Keys.ARROW_DOWN);
-
- }
- keyNavigation.perform();
-
- // The broken behavior always caused a v-shadow element to have
- // height: 10px. Verify that this does no longer happen.
-
- String cssValue = driver.findElement(By.className("v-shadow"))
- .getCssValue("height");
-
- Assert.assertNotEquals("v-shadow height should not be 10px", "10px",
- cssValue);
-
- }
-}
+++ /dev/null
-/*
- * Copyright 2000-2014 Vaadin Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.vaadin.tests.components.ui;
-
-import com.vaadin.server.VaadinRequest;
-import com.vaadin.tests.components.AbstractTestUIWithLog;
-import com.vaadin.ui.Button;
-import com.vaadin.ui.Button.ClickEvent;
-import com.vaadin.ui.ComboBox;
-
-/**
- * Test UI for adding a stylename to a combobox with an undefined width.
- *
- * @author Vaadin Ltd
- */
-public class ComboboxStyleChangeWidth extends AbstractTestUIWithLog {
-
- @Override
- protected void setup(VaadinRequest request) {
- final ComboBox cbFoo = new ComboBox();
- cbFoo.setImmediate(true);
- cbFoo.setSizeUndefined();
- cbFoo.addItem("A really long string that causes an inline width to be set");
-
- Button btn = new Button("Click to break CB",
- new Button.ClickListener() {
- @Override
- public void buttonClick(ClickEvent event) {
- cbFoo.addStyleName("foofoo");
-
- }
- });
-
- addComponent(cbFoo);
- addComponent(btn);
-
- }
-
- @Override
- protected String getTestDescription() {
- return "The computed inline width of an undefined-width ComboBox "
- + "(with a sufficiently long option string) breaks when "
- + "the component's stylename is changed after initial "
- + "rendering.";
- }
-
- @Override
- protected Integer getTicketNumber() {
- return Integer.valueOf(13444);
- }
-
-}
+++ /dev/null
-/*
- * Copyright 2000-2014 Vaadin Ltd.
- *
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not
- * use this file except in compliance with the License. You may obtain a copy of
- * the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
- * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
- * License for the specific language governing permissions and limitations under
- * the License.
- */
-package com.vaadin.tests.components.ui;
-
-import static org.junit.Assert.assertEquals;
-
-import org.junit.Test;
-
-import com.vaadin.testbench.elements.ButtonElement;
-import com.vaadin.testbench.elements.ComboBoxElement;
-import com.vaadin.tests.tb3.MultiBrowserTest;
-
-/**
- * Tests that changing a stylename will not cause the width parameter to be
- * removed from a combobox.
- *
- * @author Vaadin Ltd
- */
-
-public class ComboboxStyleChangeWidthTest extends MultiBrowserTest {
-
- @Test
- public void testWidthRetained() {
- openTestURL();
-
- ComboBoxElement comboBox = $(ComboBoxElement.class).first();
- String oldStyle = comboBox.getAttribute("style");
-
- ButtonElement button = $(ButtonElement.class).first();
- button.click();
- String newStyle = comboBox.getAttribute("style");
-
- assertEquals("width has changed, should remain equal", oldStyle,
- newStyle);
-
- }
-
-}
projects / vaadin-framework.git / commitdiff