]> source.dussan.org Git - vaadin-framework.git/commitdiff
Also hide shim iframe of VOverlay on setVisible(false) (#12731)
authorHenri Sara <hesara@vaadin.com>
Wed, 9 Oct 2013 09:31:00 +0000 (12:31 +0300)
committerVaadin Code Review <review@vaadin.com>
Mon, 14 Oct 2013 12:31:04 +0000 (12:31 +0000)
Change-Id: I48258a24bb14bbe79c1e11c9bda4a18b120b2a42

client/src/com/vaadin/client/ui/VOverlay.java

index 0e031e3d0d9945a39f13bd416f78e3596ab29daa..2f5df6d4f36afbad5c891131c2efd6d341a84c85 100644 (file)
@@ -229,6 +229,10 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
         return shadow != null;
     }
 
+    protected boolean isShimElementEnabled() {
+        return shimElement != null;
+    }
+
     private void removeShimElement() {
         if (shimElement != null) {
             shimElement.removeFromParent();
@@ -382,6 +386,10 @@ public class VOverlay extends PopupPanel implements CloseHandler<PopupPanel> {
             shadow.getStyle().setProperty("visibility",
                     visible ? "visible" : "hidden");
         }
+        if (isShimElementEnabled()) {
+            shimElement.getStyle().setProperty("visibility",
+                    visible ? "visible" : "hidden");
+        }
     }
 
     @Override